Skip to content

perf(chat): use lightweight stop markers - #1834

Merged
dcramer merged 4 commits into
mainfrom
perf/lightweight-conversation-stop-check
Sep 11, 2026
Merged

perf(chat): use lightweight stop markers#1834
dcramer merged 4 commits into
mainfrom
perf/lightweight-conversation-stop-check

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

summary

  • write a run-scoped stop marker when a Conversation stop is requested
  • poll that small marker instead of loading and parsing the full Conversation every 500ms
  • clear the marker after the worker completes the stop
  • assert the live stop poll does not read the Conversation record

This removes the dominant Redis read amplification seen in long execution slices while preserving the durable Conversation stop record for resume and recovery.

checks

  • pnpm --filter @sentry/junior typecheck
  • pnpm exec vitest run tests/component/task-execution/conversation-work.test.ts (70 tests)
  • git diff --check

via David Cramer.

--

View Junior Session [Sentry]

Co-Authored-By: David Cramer <david@sentry.io>
@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
junior-docs Ready Ready Preview Sep 10, 2026 10:38pm UTC

Request Review

Co-Authored-By: David Cramer <david@sentry.io>
@dcramer
dcramer marked this pull request as ready for review September 10, 2026 22:21
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Sep 10, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f90c9f9. Configure here.

Comment thread packages/junior/src/chat/task-execution/state.ts Outdated
@dcramer
dcramer merged commit 0097c1a into main Sep 11, 2026
40 checks passed
@dcramer
dcramer deleted the perf/lightweight-conversation-stop-check branch September 11, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant