fix(events): wait for watch event bursts - #1831
Merged
Merged
Conversation
Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This reverts commit 0283a75. Co-Authored-By: David Cramer <david@sentry.io>
Replace the flat pre-delay with a debounce owned by the event Turn worker: the first event waits 30s, each additional pending event adds 5s, and the wait is capped at 60s measured from the first event. This lets a burst of watch events collect into one Turn without needing a persisted debounce deadline or a second scheduling mechanism. Co-Authored-By: David Cramer <david@sentry.io>
dcramer
marked this pull request as ready for review
September 10, 2026 18:54
Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-Authored-By: David Cramer <david@sentry.io>
github-actions
Bot
added
risk: high
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f6b1729. Configure here.
Cursor Bugbot flagged that Slack (and any other non-web) inbound messages went through appendAndEnqueueInboundMessage without replaceExistingWake, so a pending event enqueue marker could swallow their wake and force them to wait out the event delay. Move the default to the shared enqueueAfterAppend choke point: any message whose source is not "event" now defaults to replaceExistingWake, covering Slack, dispatch, and invocation callers without needing every call site to opt in.
Non-event input must bypass an event's delayed enqueue marker, but it must not bypass a worker that already owns the conversation lease. Split those controls so Slack steering stays in the active worker without redundant queue nudges.
dcramer
reviewed
Sep 10, 2026
Add comments explaining why the mailbox worker defers a batch that starts with an event, how the debounce window grows with batch size, and why deferral re-enqueues instead of sleeping.
dcramer
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watch events now wait briefly before they start a Turn.
The wait is computed from the pending messages. It needs no new stored state.
Fixes #1829.
Checks:
via David Cramer.
--
View Junior Session [Sentry]