Skip to content

fix(evals): Include rubric judge cost - #1819

Open
sentry-junior[bot] wants to merge 8 commits into
mainfrom
fix/eval-judge-cost-accounting
Open

fix(evals): Include rubric judge cost#1819
sentry-junior[bot] wants to merge 8 commits into
mainfrom
fix/eval-judge-cost-accounting

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Rubric judge calls were missing from eval cost data.

Include each judge call's USD cost in the score metadata so the result artifact contains both application and judge costs.

via David Cramer.

--

View Junior Session [Sentry]

Co-Authored-By: David Cramer <david@sentry.io>
@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
junior-docs Ready Ready Preview Sep 10, 2026 2:35pm UTC

Request Review

Co-Authored-By: David Cramer <david@sentry.io>
@sentry-junior sentry-junior Bot changed the title fix(evals): Record rubric judge costs fix(evals): Include rubric judge cost Sep 10, 2026
@dcramer
dcramer marked this pull request as ready for review September 10, 2026 02:49
@dcramer
dcramer enabled auto-merge (squash) September 10, 2026 02:50
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Sep 10, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a7750bf. Configure here.

Comment thread packages/junior-evals/src/helpers.ts Outdated
Bugbot flagged that message.usage.cost.total can be undefined, which
made costUsd validation throw and fail otherwise-valid rubric
verdicts. Cost is now optional end to end: the judge harness run,
the RubricJudge validation, and the score metadata.
Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant