Default dashboard timestamps to the viewer's browser timezone - #1800
Merged
Conversation
…ezone Dashboard timestamps were forced to a single server-wide timezone (process.env.JUNIOR_TIMEZONE || "America/Los_Angeles"), so every viewer saw times in Pacific regardless of their own location. - Server now only reports timeZone in /api/config when an operator explicitly sets JUNIOR_TIMEZONE; otherwise the field is omitted. - Client defaults the display timezone to Intl.DateTimeFormat().resolvedOptions().timeZone (the viewer's browser timezone) and only overrides it when the server sends an explicit value. Fixes #1799 Co-Authored-By: Daniel Szoke <daniel.szoke@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
13 screenshot changes — 13 changed · 0 added · 0 removed Review screenshots in Frameshift
Show 7 more changed screenshots
|
ConversationWorkspace no longer reads props.data (timezone lookups moved to getDashboardTimeZone()), which tripped oxlint's no-unused-vars rule in CI. Drop the now-dead prop from the component and its two App.tsx call sites instead of keeping an unused parameter.
HazAT
marked this pull request as ready for review
September 9, 2026 21:05
HazAT
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1799.
Dashboard timestamps were forced to a single server-wide timezone (
process.env.JUNIOR_TIMEZONE || "America/Los_Angeles"), so every viewer saw times in Pacific regardless of their own location.Change
dashboardTimeZone()inapp.tsnow returns theJUNIOR_TIMEZONEenv var only when explicitly set, otherwiseundefined./api/config'stimeZonefield is now optional; it's omitted entirely unless an operator configured an override.format.ts) now defaults its display timezone toIntl.DateTimeFormat().resolvedOptions().timeZone(the viewer's own browser timezone), and only overrides it when the server sends an explicittimeZone.ConversationWorkspace.tsxthat read the raw (now possibly-undefined) config field to use the resolvedgetDashboardTimeZone()helper instead.Testing
pnpm --filter @sentry/junior-dashboard run typecheckpasses.pnpm --filter @sentry/junior-dashboard exec vitest run— 313/313 tests pass (updateddashboard-routes.test.tsandtelemetry-components.test.tsxfor the new default/override behavior).Not addressed
The related 12h/24h hour-format issue (
hourCycle) is a separate browser/locale limitation, not something this app can reliably control — not in scope here.via Daniel Szoke.
--
View Junior Session in Sentry