chore(deps): update Danger JS to v13.0.10#172
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
0c45415 to
b205160
Compare
b205160 to
b551b9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps danger/danger.properties from 13.0.5 to 13.0.10.
Auto-generated by a dependency updater.
Changelog
13.0.9
13.0.6
danger localshell execution possibility [Junming]13.0.5
Dropped p-limit as a dep
Force no-color in git for the local command - cyberowl
Use stdout/err in local command - cyberowl
Ensure that babel ignores do not cause the transpiler to fall over, by supporting the
danger.github.setSummaryMarkdown("[markdown]")for the JavaScript DSLThe results DSL for sub-processes now accepts
{ github: { stepSummary: "[markdown]" } }from projects the Swift and Kotlin implementations of Danger.No breaking changes - I'm just bumping it because it's a lot of under-the-hood work, and I've not been able to test it
https://platform.github.community/t/obtaining-the-id-of-the-bot-user/2076 )
lot of output. This should make it much easier to understand what's going on. - [orta]
commands do and it's is still even worse in Danger ruby. I figure now is as good a time as any a good time to call
danger.js.flowfix to handle exports correctly, you probably need to addon_exitcalls of the process to know that all work is done. So, in Danger (not in Peril) async code will workInvestigate into a fully separated peril system, by using AWS Lambda for a Danger run danger/peril#159
tested it yet though. Turns out this change is real hard to write tests for. I've made #394 for that.
The massive downside to this is that Danger now has to have support for transpiling via Babel, or from TypeScript
TL;DR
warnings/errors ) (note: in changing this for Danger, I had to also add thedangerfile.tsto the"exclude"danger.github.issue- As a PR is an issue in GitHub terminology, the issue contains a bit more metadata. Mainlydanger.github.reviews- Find out about your reviews in the new GitHub Reviewer systems,danger.github.requested_reviewers- Find out who has been requested to review a PR.prprobably won't be sticking around for the long run, but if you're using a0.0.2release, you should be OK with[dimitar-hristov]: https://github.com/dimitar-hristov
[HonzaMac]: https://github.com/HonzaMac
[JanStevens]: https://github.com/JanStevens
[radimsv]: https://github.com/radimsv
[RDIL]: https://github.com/RDIL
[Teamop]: https://github.com/Teamop
[thawankeane]: https://github.com/thawankeane
[tychota]: https://github.com/tychota
[urkle]: https://github.com/urkle
[valscion]: https://github.com/valscion
[wardpeet]: https://github.com/wardpeet
[watchinharrison]: https://github.com/watchinharrison
[wizardishungry]: https://github.com/wizardishungry
[yohix]: https://github.com/yohix
[zdenektopic]: https://github.com/zdenektopic
[danger-go]: https://github.com/bdotdub/danger-go
[danger-swift]: https://github.com/danger/danger-swift#danger-swift
Full CHANGELOG.md diff
DANGER_FAKE_CIetc. [orta]10.3.1
-722,7 +736,7 Reverts a change for GitHub Actions which was likely causing duplicate comments
5.0.0
-No breaking changes - I'm just bumping it because it's a lot of under-the-hood work, and I've not been able to test it
+No breaking changes - I'm just bumping it because it's a lot of under-the-hood work, and I've not been able to test it
thoroughly in production.
This release bring support for GitHub actions. It does this merging in some of the responsibilities that used to live
-740,7 +754,7 Notes about Danger JS:
one in your project
-943,7 +957,7 Also,
danger prnow accepts a--processarg.Instead there are two options:
The security model of the GitHub app means it's totally safe to use our GitHub app, it can only read/write to checks
-1024,7 +1038,7 Also,
danger prnow accepts a--processarg.3.4.4
-- Fixed a bug where Danger would get access to all inline comments, thus deleting comments posted by other people
+- Fixed a bug where Danger would get access to all inline comments, thus deleting comments posted by other people
[sunshinejr]
3.4.3
-1223,7 +1237,7 You'll need to have husky installed for t
3.0.1
DEBUG="*" yarn danger [etc]and you'll get a3.0.0
-1242,12 +1256,12 You'll need to have husky installed for t
This release deprecates running
dangeron it's own, so if you haveyarn dangerthen move that beyarn danger ci.Each command name is now much more obvious in it intentions, I've heard many times that people aren't sure what
commands do and it's is still even worse in Danger ruby. I figure now is as good a time as any a good time to call
it a clean slate.
On a positive note, I gave all of the help screens an update and tried to improve language where I could.
-* [orta]
+- [orta]
2.1.9-10
-1303,7 +1317,7 You'll need to have husky installed for t
2.0.0
-- Fixes the
danger.js.flowfix to handle exports correctly, you probably need to add+- Fixes the
danger.js.flowfix to handle exports correctly, you probably need to add.*/node_modules/danger/distribution/danger.js.flowto the[libs]section of your settings for it to work though -[orta]
-1320,7 +1334,7 You'll need to have husky installed for t
created
schedulefor. Previously, any async work in your Dangerfile needed to be declared to Danger so that itknew when all of the work had finished. Now that the running happens inside another process, we can use the
on_exitcalls of the process to know that all work is done. So, in Danger (not in Peril) async code will workon_exitcalls of the process to know that all work is done. So, in Danger (not in Peril) async code will workjust like inside a traditional node app.
danger processa first class citizen. This is awesome because there will be reliable support for other-1338,11 +1352,11 You'll need to have husky installed for t
Moves away from vm2 to a require-based Dangerfile runner. This removes the sandboxing aspect of the Dangerfile
completely, but the sandboxing was mainly for Peril and I have a plan for that.
-danger/peril#159
+danger/peril#159
I would like to move the main parts of Danger JS to also work like
danger process, so I'll be continuing to work as aalpha for a bit more. One interesting side-effect of this could be that I can remove
schedulefrom the DSL. I've not-tested it yet though. Turns out this change is real hard to write tests for. I've made #394 for that.
+tested it yet though. Turns out this change is real hard to write tests for. I've made #394 for that.
./[orta]
-1478,7 +1492,7 Some UX fixes:
I like to think of it as having gone from Jest's runner which is a massive toolbox, to vm2 which is a tiny toolbox
where I'll have to add a bunch of new tools to get everything working.
unlike before, where it was a freebie inside Jest. Jest handled this so well. This means that a Dangerfile which used
to "just work" with no config may not. Thus, IMO, this is a breaking major semver.
-1632,7 +1646,7 If these files are supposed to not exist, please update your PR body to include
Added
result.beforeandresult.afterfor easy access to full contents of the original & updated filedanger.git.diffForFileis now anasyncfunctionTL;DR:
TL;DR
// In danger 0.16.0:-1686,7 +1700,7 If these files are supposed to not exist, please update your PR body to include
This is built on top of Jest's custom transformers, so if you are already using Jest with TypeScript, then you can
change the
dangerfile.jstodangerfile.tsand nothing should need changing ( except that you might have newdangerfile.tsto the"exclude"warnings/errors ) (note: in changing this for Danger, I had to also add the
dangerfile.tsto the"exclude"section of the
tsconfig.jsonso that it didn't change the project's root folder.)This repo is now using both a babel Dangerfile (running on Circle CI) and a TypeScript one (running on Travis) to
-1807,10 +1821,10 If these files are supposed to not exist, please update your PR body to include
-*
danger.github.issue- As a PR is an issue in GitHub terminology, the issue contains a bit more metadata. Mainly+-
danger.github.issue- As a PR is an issue in GitHub terminology, the issue contains a bit more metadata. Mainlylabels, so if you want to know what labels are applied to a PR, use
danger.github.issue.labels-*
danger.github.reviews- Find out about your reviews in the new GitHub Reviewer systems,-*
danger.github.requested_reviewers- Find out who has been requested to review a PR.+-
danger.github.reviews- Find out about your reviews in the new GitHub Reviewer systems,+-
danger.github.requested_reviewers- Find out who has been requested to review a PR.-1990,7 +2004,7 git
fail(message: string)