Skip to content

fix(github): resolve latest release via REST API to avoid flaky GraphQL 401 #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
malept wants to merge 1 commit into from
+11 −3
Closed

fix(github): resolve latest release via REST API to avoid flaky GraphQL 401 #1156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions shell/lib/github.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,24 @@ github_token() {
}

# Determines the latest release version of a GitHub repository.
#
# This uses the REST API rather than `gh release list` because the
# latter relies on GitHub's GraphQL API, which intermittently returns
# 401 Unauthorized for some organization repositories.
latest_github_release_version() {
local slug="$1"
local use_pre_releases="$2"

local gh_args=(--limit 1 --json tagName --jq '.[].tagName' --exclude-drafts)
# Filter out drafts, and pre-releases unless they're requested, then
# print the tag name of the most recent matching release. Releases are
# returned newest-first by the API.
local jq_filter='[.[] | select(.draft == false)'
if [[ $use_pre_releases != "true" ]]; then
gh_args+=(--exclude-pre-releases)
jq_filter+=' | select(.prerelease == false)'
fi
jq_filter+='] | first | .tag_name // empty'

run_gh release --repo "$slug" list "${gh_args[@]}"
run_gh api "repos/$slug/releases" --jq "$jq_filter"
}

# install_latest_github_release downloads the latest version of a tool
Expand Down