Skip to content

fix(release): set up gh-based git credentials #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malept merged 3 commits into from
May 28, 2026
Merged

fix(release): set up gh-based git credentials #1152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09ac2d8
fix(release): set up gh-based git credentials
malept May 28, 2026
b545481
Add to dryrun script too
malept May 28, 2026
c401794
chore: fix poorly worded error messages
malept May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion shell/ci/release/dryrun.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,11 @@ if ! git diff --quiet "$OLD_CIRCLE_BRANCH"; then

GITHUB_TOKEN="$(github_token)"
if [[ -z $GITHUB_TOKEN ]]; then
warn "Failed to read Github personal access token" >&2
warn "Failed to read GitHub token" >&2
fi

run_gh auth setup-git

MISE_GITHUB_TOKEN="$GITHUB_TOKEN" GH_TOKEN="$GITHUB_TOKEN" \
yarn --frozen-lockfile semantic-release --dry-run

Expand Down
4 changes: 3 additions & 1 deletion shell/ci/release/pre-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ if [[ $CIRCLE_BRANCH != "$prereleasesBranch" ]] && [[ $DRYRUN == "false" ]]; the
exit 0
fi

run_gh auth setup-git

# If we're in dry-run mode, skip creating the release.
if [[ $DRYRUN == "true" ]]; then
exit 0
Expand All @@ -85,7 +87,7 @@ if [[ $COMMIT_MESSAGE =~ "chore: Release" ]]; then
# Retrieve the GH_TOKEN
GH_TOKEN=$(github_token)
if [[ -z $GH_TOKEN ]]; then
echo "Failed to read Github personal access token" >&2
echo "Failed to read GitHub token" >&2
fi
# Unset NPM_TOKEN to force it to use the configured ~/.npmrc
NPM_TOKEN='' GH_TOKEN=$GH_TOKEN \
Expand Down
4 changes: 3 additions & 1 deletion shell/ci/release/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@ source "${LIB_DIR}/logging.sh"
# Retrieve the GH_TOKEN
GITHUB_TOKEN="$(github_token)"
if [[ -z $GITHUB_TOKEN ]]; then
error "Failed to read GitHub personal access token"
error "Failed to read GitHub token"
fi

run_gh auth setup-git

send_failure_notification() {
if [[ -z $RELEASE_FAILURE_SLACK_CHANNEL ]]; then
fatal "Failed to release"
Expand Down