Repository navigation
fix: lift the stale milpa/core ceiling that dragged whole apps backwards - #9
Merged
Merged
Conversation
milpa/core was capped at ^0.7, which excluded 0.8, 0.9 and 0.10. Because milpa/orchestrator requires this package, that ceiling propagated: a fresh 'composer create-project milpa/framework' app that then required the orchestrator had milpa/core rolled back from 0.10.0 to 0.7.1 and milpa/live from 0.18 to 0.15, and a subsequent 'composer require milpa/admin' silently resolved to admin 0.5.2 instead of 0.12.0 — the panel from before Milpa Components, before declared views, before the passkey gate. Composer reported success and the app booted. Adopting Milpa's workflow engine quietly cost the adopter every other current package. The ceiling protected nothing: this package's 134 tests, its coverage floor, its docblock, attribution and style gates and phpstan all pass unchanged against milpa/core 0.10.0. It was simply never raised again. Measured on cattle from the greenhouse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
milpa/corewas capped at^0.6.2 || ^0.7, excluding 0.8, 0.9 and 0.10.Because
milpa/orchestratorrequires this package, that ceiling propagated to every app that adopts Milpa's workflow engine. Measured on a freshcomposer create-project milpa/frameworkapp:Composer reports success. The app boots. The adopter silently gets the panel from before Milpa Components, before declared views, before the passkey gate.
The ceiling protected nothing
Against
milpa/core0.10.0, unchanged: 134/134 tests, coverage 91.44% (floor 90), phpstan clean, docblock / attribution / style gates green,composer validate --strictclean.It was never raised again after core moved on — nobody owns the ranges.
Change
One line:
"milpa/core": "^0.6.2 || ^0.7"→">=0.6.2 <1.0", matching the constraint style the rest of the platform already uses.