Repository navigation
fix: what Composer installs carries no tests, nor a machine's name or key with them - #53
Merged
Merged
Conversation
… key with them The version of this package that Composer installs today still carries its tests, and in them a machine's name, a home path and the fingerprint of a signing key of the place they were written in. Both are already put right on main: the tests are marked out of the archive, and the tests name a made-up operator. But those two commits are a chore and a test, and neither cuts a release, so nothing published has changed. This is the commit that publishes it. It adds the one thing that was missing: a test that holds the line of .gitattributes, and that builds the archive of the commit and finds no test in it. Without that line the tests travel again, and nothing in the package said so. It also replaces, in one test, a recorded status line of the signature verifier: the key id and the fingerprint it carried came from a real run. They are made-up ones now, and the line keeps its shape. The release this cuts is the first whose archive carries neither.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of this package that Composer installs today still carries
its tests, and in them a machine's name, a home path and the fingerprint
of a signing key of the place they were written in. Both are already put
right on
main: the tests are marked out of the archive, and the testsname a made-up operator. But those two commits are a
choreand atest, and neither cuts a release, so nothing published has changed.This is the commit that publishes it. It adds the one thing that was
missing: a test that holds the line of
.gitattributes, and that buildsthe archive of the commit and finds no test in it. Without that line the
tests travel again, and nothing in the package said so.
It also replaces, in one test, a recorded status line of the signature
verifier: the key id and the fingerprint it carried came from a real
run. They are made-up ones now, and the line keeps its shape.
The release this cuts is the first whose archive carries neither.