Repository navigation
fix: milpa/core is a dev-time tool here, not a runtime dependency - #12
Merged
Merged
Conversation
milpa/ops declared milpa/core in `require` and used not one line of it. Its only mention anywhere in the package is a docblock sentence comparing an interface to core's. What it actually needs core for is `tools/gen-docs.php`, which reaches the family's docs generator through this package's own autoload-dev mapping (`Milpa\Docs\` → `vendor/milpa/core/tools/gen-docs/`) — a dev-time entry point. Measured against a path-repo consumer with `--no-dev`: before, installing milpa/ops pulled milpa/core, psr/container and psr/event-dispatcher; after, it pulls psr/log alone. Suite green (69 tests) and gen-docs still generates its 31 pages with core in require-dev. Follows greenhouse decisions/0237.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
milpa/opsdeclaredmilpa/coreinrequireand used not one line of it. The only mention of core anywhere in the package is a docblock sentence insrc/Cron/CronProviderInterface.phpcomparing its shape to core’sToolProviderInterface.What ops actually needs core for is
tools/gen-docs.php, which reaches the family’s docs generator through this package’s ownautoload-devmapping (Milpa\Docs\→vendor/milpa/core/tools/gen-docs/). That is a dev-time entry point, so the declaration belongs inrequire-dev.Measured, with a positive control. A scratch consumer requiring
milpa/opsthrough a path repo, resolved with--no-dev:milpa/corev0.12.0,psr/container,psr/event-dispatcher,psr/logpsr/logThree packages leave the production graph of every consumer, and none of them was ever used.
Suite green (69 tests, 193 assertions), and
php tools/gen-docs.phpstill generates its 31 pages with core inrequire-dev.Follows greenhouse
decisions/0237, where the family-wide census that found this is corrected to tell a tool dependency apart from an unexplained one.