Skip to content

feat: edit says it amends the class it names (greenhouse decisions/0596) - #146

Merged
rodrigoteamx merged 1 commit into
mainfrom
hp/greenhouse/t-0104-edit-amends-its-target
Oct 8, 2026
Merged

rodrigoteamx merged 1 commit into
mainfrom
hp/greenhouse/t-0104-edit-amends-its-target

Conversation

@rodrigoteamx

@rodrigoteamx rodrigoteamx commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

edit declares that it amends the class it names (greenhouse decisions/0596, decided by Rod on 2026-10-07). This package runs no gate, so nothing changes here: the session's floor in milpa/app-runtime is who reads it.

Why

implement declares that it creates its named target, so a request that does not name the class is not asked about it; edit selects a class that exists, and is. The record of the lab's houses says what that question fell on: 28 of 34 times, a class the same session had brought into the house a moment before, and never a class the record shows in the house from before the session. Each of those questions ended a leg.

edit now says what it does — it amends, in place, a class that exists — and the floor decides, from the session's own record, whether the class is one the session itself brought, or whether the call repairs a proposal of that session. Everything else is asked as before. edit still never creates a class: only make does.

What it does

  • edit carries amendsNamedTarget: true wherever the installed Operation can carry it.
  • The declaration is made around the contract, not inside it: it was born in a later milpa/command than the oldest this package runs with, and a named argument the installed Operation does not know is a fatal error when the catalogue is built. Where the contract cannot carry it, edit is declared exactly as before and the floor keeps asking.
  • implement keeps saying it creates; nothing else in the package says it amends.

The requirement on milpa/command does not move

It stays >=0.24. Over an older milpa/command this package is what it was; and the one consumer that acts on the declaration, milpa/app-runtime, requires the milpa/command that carries it — so wherever the rule runs, the declaration is made.

How it was checked

  • Tests written first and seen red: AnEditAmendsTheClassItNamesTest (4). Over a milpa/command that cannot carry the declaration three of them skip, saying why, and the fourth shows the catalogue is declared all the same.
  • Hand mutants: 4 of 4 red (greenhouse scripts/lab/edit-1143/mutants.py devtools).
  • 813 tests over milpa/command 0.29.0, none skipped, line coverage 95.58 % (floor 95); PHPStan on both contracts, style, DocBlocks, attribution.
  • On fresh cattle, with this branch and the two others laid over the published train (greenhouse evidence/1143).

implement declares that it creates its named target, so a request that does not name the class is not asked about it; edit selects a class that exists, and is. The record of the lab's houses says what that question fell on: 28 of 34 times, a class the same session had brought into the house a moment before.

edit now declares what it does: it amends, in place, a class that exists. The session's floor decides, from that session's own record, whether the class is one the session itself brought; this package runs no gate, so nothing changes here.

The declaration was born in a later milpa/command than the oldest this package runs with. It is made around the contract, not inside it: where the installed Operation cannot carry it, edit is declared exactly as before and the floor keeps asking.
@rodrigoteamx
rodrigoteamx force-pushed the hp/greenhouse/t-0104-edit-amends-its-target branch from 71bd976 to c01e20a Compare October 8, 2026 00:01
@rodrigoteamx
rodrigoteamx merged commit 51dd224 into main Oct 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant