Repository navigation
feat: edit says it amends the class it names (greenhouse decisions/0596) - #146
Merged
Merged
Conversation
implement declares that it creates its named target, so a request that does not name the class is not asked about it; edit selects a class that exists, and is. The record of the lab's houses says what that question fell on: 28 of 34 times, a class the same session had brought into the house a moment before. edit now declares what it does: it amends, in place, a class that exists. The session's floor decides, from that session's own record, whether the class is one the session itself brought; this package runs no gate, so nothing changes here. The declaration was born in a later milpa/command than the oldest this package runs with. It is made around the contract, not inside it: where the installed Operation cannot carry it, edit is declared exactly as before and the floor keeps asking.
rodrigoteamx
force-pushed
the
hp/greenhouse/t-0104-edit-amends-its-target
branch
from
October 8, 2026 00:01
71bd976 to
c01e20a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
editdeclares that it amends the class it names (greenhouse decisions/0596, decided by Rod on 2026-10-07). This package runs no gate, so nothing changes here: the session's floor in milpa/app-runtime is who reads it.Why
implementdeclares that it creates its named target, so a request that does not name the class is not asked about it;editselects a class that exists, and is. The record of the lab's houses says what that question fell on: 28 of 34 times, a class the same session had brought into the house a moment before, and never a class the record shows in the house from before the session. Each of those questions ended a leg.editnow says what it does — it amends, in place, a class that exists — and the floor decides, from the session's own record, whether the class is one the session itself brought, or whether the call repairs a proposal of that session. Everything else is asked as before.editstill never creates a class: onlymakedoes.What it does
editcarriesamendsNamedTarget: truewherever the installedOperationcan carry it.Operationdoes not know is a fatal error when the catalogue is built. Where the contract cannot carry it,editis declared exactly as before and the floor keeps asking.implementkeeps saying it creates; nothing else in the package says it amends.The requirement on milpa/command does not move
It stays
>=0.24. Over an older milpa/command this package is what it was; and the one consumer that acts on the declaration, milpa/app-runtime, requires the milpa/command that carries it — so wherever the rule runs, the declaration is made.How it was checked
AnEditAmendsTheClassItNamesTest(4). Over a milpa/command that cannot carry the declaration three of them skip, saying why, and the fourth shows the catalogue is declared all the same.scripts/lab/edit-1143/mutants.py devtools).