Repository navigation
fix: the example of a storage path shows a placeholder where the name is the caller's - #16
Merged
Merged
Conversation
… is the caller's The teaching error of the file driver showed a path with a collection of its own choosing. That error is read by whoever configures storage, whatever they are building. Its example now shows the form of the path: '/var/data/<collection>.json'. Tested positively: where the example of a driver's key has to name the thing being stored into, it shows a placeholder for what is the caller's to name, or the app itself.
A house that installs this package received its tests too: as many bytes as the code it runs, and never run there. They are marked out of the archive Composer downloads. Nothing else is: the tools and the workflows of a package can be read by others from that same archive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The teaching error of the file driver showed a path with a collection
of its own choosing. That error is read by whoever configures storage,
whatever they are building. Its example now shows the form of the path:
'/var/data/<collection>.json'.Tested positively: where the example of a driver's key has to name the
thing being stored into, it shows a placeholder for what is the
caller's to name, or the app itself. With the error as it was, that
test is red.
One cost, measured: a path copied with its placeholder is accepted, and
the rows land in a file of that name. Nothing refuses it.
The second commit keeps
tests/out of the archive Composer installs.