Repository navigation
fix(tui): the shell form runs an authoring op with the token's authority - #105
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
coa shellform ran an operation with no authority, so the plugin-authoring policy fell to the local wildcard (ToolContext::cli()) and a finite token's authoring op (e.g.test) ran IN THE HOUSE, unconfined. The form now runs with the session's presented-tokenToolContext, exactly as the terminal does:OperationScreen/OperationsScreentake an optional authority and forward it toOperationRunner::run; the app-runtime side (Application::pantallaDelShell) builds it from the presented token. With a token the authoring op is confined to the token's finite scopes; with no token it stays the operator wildcard, unchanged. Strictly narrowing. Pairs with getmilpa/app-runtime#807.