Repository navigation
fix: the testing signer and the tests carry a made-up fingerprint, host and home - #101
Merged
Merged
Conversation
…st and home The tests of this package carried a machine name, a home path and the fingerprint of a signing key of the place they were written in, as the example an assertion compares against. A public repository says nothing of the machine it was written on. Each one is now made up: the principal is `cli:operator@workstation`; paths sit under `/home/operator`; the fingerprint is `AAAA1111BBBB2222CCCC3333DDDD4444EEEE5555`, one nobody holds. The tests assert what they asserted; only the literal changed. One of them was in code this package ships: the signer its testing helper hands back carried that fingerprint. It carries the made-up one now. Nothing else in the helper changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests of this package carried a machine name, a home path and the
fingerprint of a signing key of the place they were written in, as the
example an assertion compares against. A public repository says nothing
of the machine it was written on.
Each one is now made up: the principal is
cli:operator@workstation;paths sit under
/home/operator; the fingerprint isAAAA1111BBBB2222CCCC3333DDDD4444EEEE5555, one nobody holds. The testsassert what they asserted; only the literal changed.
One of them was in code this package ships: the signer its testing
helper hands back carried that fingerprint. It carries the made-up one
now. Nothing else in the helper changes.