Repository navigation
lab: a leg is told what its session scaffolded and has not written (experiment of greenhouse decisions/0604 — held) - #762
Draft
rodrigoteamx wants to merge 2 commits into
Draft
rodrigoteamx wants to merge 2 commits into
rodrigoteamx wants to merge 2 commits into
Conversation
…an experiment of greenhouse decisions/0604, held
Contributor
Author
|
Superseded by #766, which builds rule D of greenhouse decisions/0604 as Rod decided it: it reads what landed, not the calls a session made, and says it on every call instead of once. This draft stays open only until the coordinator closes it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Held — an experiment, not a proposal to merge
This is the small part of greenhouse decisions/0604 built as an experiment. decisions/0604 is a design in STOP: Rod has not decided it. This pull request is a draft so that the code is kept and can be read; it is not to be merged. Remove this block only if Rod decides to take it.
What it does
The run context a leg already receives at the start of an invocation gains one key,
scaffolded_not_written, and one sentence that says what it is: the operations this session scaffolded and has no later accepted authoring call for. It is read from the session's own recorded calls — no model, no list — and it is said only when there is something to say: otherwise the section is byte for byte what it was.Why
A leg that inherits a fold is told the session's own plan and todos, and of a past call only a few names; that an operation was scaffolded and its body never written is not a fact anywhere. In the legs that followed one that ran out of window, 15 of 31 reads were of something an earlier leg had already read (greenhouse evidence/1164).
What one real run said
It ran once with a real resident, measured by another thread, and the run did not pass. The datum arrived once, at the start of the third leg, with four entries, and it was true; after receiving it the session wrote two of the four. One run with no control decides nothing.
Its limits, stated in the class
Checks
Its tests and the run context's; 10 of 10 hand mutants red; the whole suite green (3,805 tests, line coverage 95.44 %).