Repository navigation
fix: the example of a terminal principal names nobody (greenhouse evidence/1192) - #128
Merged
Merged
Conversation
…dence/1192) A docblock of src/ and one test wrote a terminal principal with a person's user name. Both say cli:operator@example.com now. The docblock travels in the archive. A public repository carries no identifier of a person or of a machine (greenhouse evidence/1144, evidence/1192).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A public repository carries no identifier of a person (greenhouse
evidence/1144,evidence/1192). A docblock ofsrc/Principal.phpand one test wrote a terminal principal with a person's user name.Both say
cli:operator@example.comnow; the test builds it withfromTerminal('operator', 'example.com')and asserts the same thing. The docblock travels in the archive.Checked
php-cs-fixer clean · PHPStan no errors · 375 tests, 1,469 assertions, all green.
After the change
The scanner — every tracked file of this branch, and
git archive HEAD(what the registry would serve) — returns zero lines of the classes it lists.Nothing is released from here.