Repository navigation
test: no fixture names a lab machine (greenhouse evidence/1144) - #127
Merged
Merged
Conversation
Six lines of the tests used the mDNS name of a lab machine as a fixture endpoint. They become model.example, a reserved name that is nobody's. Nothing in src/ named it, and the package's archive carries no tests. A public repository names no machine it was written on (greenhouse evidence/1144), and a published package carries no host identifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A public repository names no machine it was written on (greenhouse
evidence/1144). Six lines of this one's tests did: fixture endpoints spelled the mDNS name of a lab machine.They become
model.example, a reserved name that is nobody's. Nothing undersrc/named it and the package's archive carries no tests, so nothing published changes.Checked
php-cs-fixer clean · PHPStan no errors · 375 tests, 1,469 assertions, all green.
After the change
The scanner that found it — every tracked file of this branch, and
git archive HEAD(what the registry would serve) — returns zero lines that name a machine.Nothing is released from here.