build(deps): remove dependencies nothing references - #157
Merged
Merged
Conversation
Drop shell-words, etcetera and owo-colors, the insta and predicates dev-dependencies, and clap's cargo feature: no source, test or build script uses them. clap_complete stays for the planned completions. The packages list now names anstyle alone for styling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.toml: removesshell-words,etceteraandowo-colorsfrom[dependencies], theinstaandpredicatesdev-dependencies, and clap'scargofeature, together with the comments that described the removed crates. None of them is referenced undersrc/,tests/,build.rsorbench/.clap_completestays, since CLAUDE.md commits to it for completions.Cargo.lock: refreshed by cargo. It dropsetcetera,float-cmp,insta,normalize-line-endings,regex,shell-wordsand thesimilar2.7.0 that onlyinstaused.owo-colorsandpredicatesstay in the lockfile only as transitive dependencies, ofcolor-eyreandassert_cmdrespectively.CLAUDE.md(AGENTS.mdis a symlink to it, so both change): the packages line "anstyle / owo-colors" now reads "anstyle". Colour comes from anstyle (src/plan/diff.rs).Validation
cargo fmt --check: passcargo clippy --all-targets --locked -- -D warnings: passcargo test --locked: pass (2040 unit tests plus every integration suite; 0 failed)line-check,convco): passRisks and rollout
publish = falseand ships only as the install.sh binary, so no downstream crate is affected.bx --versionis built bybuild.rs, not clap'scargomacros, and still compiles. To reverse, put the removed lines back inCargo.toml.Issue
Closes #145
Decisions taken
AGENTS.mdseparately fromCLAUDE.md. Taken: edit onlyCLAUDE.md. Rejected: a separate edit, becauseAGENTS.mdis a symlink toCLAUDE.md(ls -l AGENTS.md), so it already shows the change. Reverse: nothing to reverse.