Repository navigation
Adopt GetBible SWORD 0.4.0 for verified study text - #12
Merged
Merged
Conversation
Pin the new release and prefer its normalized source and stripped text without reapplying source encodings or falling back to unsafe projections. Preserve NDJSON verification, source records, diagnostics, and v1 API shapes.
Keep the established key decoder for legacy UTF-8 and single-byte indexes. GetBible SWORD normalizes source bodies, not index keys; real Easton keys still contain malformed bytes, so changing their decoding changes v1 URLs. Cover the real index bytes while keeping source-body decoding strict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The study builder still pins GetBible SWORD 0.1.1. Release 0.4.0 adds strictly decoded UTF-8 source projections, detects corrupted SWORD strip output, and repairs current-entry attribute extraction. Merely changing the executable version would leave the builder decoding legacy fields and missing these improvements.
This change pins the public 0.4.0 release and both architecture hashes, synchronizes the extractor's v1 schema, and consumes verified
normalized_raw/normalized_strippedbytes as strict UTF-8. Both API writers retain their source-aware TEI/OSIS/ThML conversion, so line boundaries, note bodies, character references, and scripture references benefit from the normalized source.Explicitly unavailable source decoding is reported after stream verification, preserving extractor diagnostics and existing module recovery. Unavailable stripped text can still be recovered from valid source markup. Legacy rendered/stripped bytes remain verified and retained, but cannot override an unavailable normalized projection. Older v1 streams omitting both additions retain compatibility. The existing key decoder remains in use for UTF-8/single-byte dictionary indexes so malformed legacy keys, including Easton's actual index bytes, keep their existing v1 IDs and URLs. SCSU/UTF-16 source-body codecs are not applied to UTF-8 keys. This key compatibility rule does not relax normalized body decoding.
Public dictionary/commentary v1 schemas, paths, identifiers, reference shapes, and complete-download composition are unchanged. Original records, corrected official attributes, and unknown additive fields remain available internally. No generated API trees are published by this PR.
Validation:
adaa342b7697cf7373f098dbbedbd279b8338924. The two live matrices cover 12 distinct dictionary/commentary modules, including the large Luther corpus.