fix: don't show missing provider CLIs as updates in the sidebar badge - #1240
Open
patleeman wants to merge 1 commit into
Open
fix: don't show missing provider CLIs as updates in the sidebar badge#1240patleeman wants to merge 1 commit into
patleeman wants to merge 1 commit into
Conversation
A provider CLI that is not installed produced a machine issue ('X CLI not
installed') that the sidebar badge rendered as a brand chip with the
aria-label 'X update available', even though there is no installed version
to update. Codex was affected the same way as Claude Code.
The badge now only surfaces issues where the CLI is actually installed and
stale (needsUpdate or versionUnsupported). Missing installs remain visible
in Settings → Updates, which already renders the install prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
The small chip in the sidebar footer's bottom-right corner advertised an update available for Claude Code even on machines where Claude Code was never installed. Clicking it just opened the Updates page, where the row actually said "Not installed" with an Install button — there was no update to apply at all. Codex behaved the same way.
Why
The daemon correctly reports
needsUpdate: falsewhen a CLI isn't installed — the confusion was purely in the UI. The badge builds its "stale agent" marks from every provider issue the Updates page surfaces, and "X CLI not installed" is one of those issues. So a missing CLI (an install prompt) was rendered as a brand chip labeled "X update available".The fix
The sidebar badge now only counts provider issues where the CLI is actually installed and stale (
needsUpdateorversionUnsupported). Missing CLIs no longer produce an update chip.Nothing else changes: Settings → Updates still shows the "Not installed" row with its Install action, which is the right place for it. The bb-app/desktop update chip is unaffected.
Tests
Added two cases to
SidebarUpdatesBadge.test.tsx:Full
@bb/appsuite passes (325 files, 2453 tests), typecheck clean.