Skip to content

Add support for PEP 517. - #135

Merged
justb4 merged 1 commit into
geopython:masterfrom
sebastic:pep517
Jun 3, 2026
Merged

Add support for PEP 517.#135
justb4 merged 1 commit into
geopython:masterfrom
sebastic:pep517

Conversation

@sebastic

@sebastic sebastic commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Using setup.py directly is deprecated.

@justb4

justb4 commented Jun 3, 2026

Copy link
Copy Markdown
Member

Thanks, I need to understand first: so we keep setup.py ? Have not looked in a while, but am happy to make Stetl more current for builds and Pypi. I have seen uv but not yet tried. Do we need to change documentation as well?

@sebastic

sebastic commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, I need to understand first: so we keep setup.py ?

Yes, setup.py is still a setuptools configuration file, see:

https://packaging.python.org/en/latest/discussions/setup-py-deprecated/

Have not looked in a while, but am happy to make Stetl more current for builds and Pypi.

The changes in this PR were motivated by the Debian packaging which can now use pybuild-plugin-pyproject instead of deprecated setup.py commands.

I have seen uv but not yet tried.

That seems like overkill for this project.

Project metadata can be moved from setup.py to pyproject.toml but there is no pressing need to do that.

Do we need to change documentation as well?

docs/install.rst could do with an update to not suggest to setup.py install, but I doubt any humans actually read that.

@justb4
justb4 self-requested a review June 3, 2026 17:28
@justb4 justb4 added this to the Version 2.2 milestone Jun 3, 2026

@justb4 justb4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, go.

@justb4
justb4 merged commit 9274097 into geopython:master Jun 3, 2026
1 check passed
@sebastic
sebastic deleted the pep517 branch June 3, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants