Skip to content

refactor(ui): one marking surface, invoked two ways #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pskeshu merged 1 commit into from
Sep 6, 2026
Merged

refactor(ui): one marking surface, invoked two ways #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
222 changes: 0 additions & 222 deletions gently/ui/web/static/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3860,39 +3860,11 @@ kbd {
background: var(--bg-card);
}

/* ========================================
EMBRYOS TAB - Subtab Bar
======================================== */

.embryos-subtab-bar {
display: none; /* Merged into embryo rail */
}

.embryos-subtab {
padding: 0.6rem 1.2rem;
cursor: pointer;
color: var(--text-muted);
font-size: 0.85rem;
font-weight: 500;
border-bottom: 2px solid transparent;
transition: color 0.2s, border-color 0.2s;
user-select: none;
}

.embryos-subtab:hover {
color: var(--text);
}

.embryos-subtab.active {
color: var(--accent);
border-bottom-color: var(--accent);
}

.embryos-subtab .marking-badge {
font-size: 0.7rem;
margin-left: 0.3rem;
}

/* ========================================
EMBRYOS TAB - Marking
======================================== */
Expand All @@ -3904,41 +3876,6 @@ kbd {
min-height: 0;
}

.marking-placeholder {
flex: 1;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
gap: 0.5rem;
color: var(--text-muted);
}

.marking-placeholder-icon {
font-size: 2.5rem;
opacity: 0.4;
}

.marking-placeholder-text {
font-size: 1.1rem;
font-weight: 500;
}

.marking-placeholder-hint {
font-size: 0.8rem;
max-width: 360px;
text-align: center;
line-height: 1.5;
}

.marking-active {
flex: 1;
display: flex;
gap: 1rem;
padding: 1rem 1.5rem;
min-height: 0;
}

.marking-viewer {
flex: 1;
display: flex;
Expand All @@ -3957,124 +3894,6 @@ kbd {
margin-bottom: 0.5rem;
}

.marking-instructions {
font-size: 0.85rem;
color: var(--text-muted);
}

.marking-actions {
display: flex;
gap: 0.5rem;
}

.marking-action-btn {
padding: 0.35rem 0.8rem;
border: 1px solid var(--border);
border-radius: 6px;
background: var(--bg-card);
color: var(--text);
cursor: pointer;
font-size: 0.8rem;
transition: background 0.15s;
}

.marking-action-btn:hover:not(:disabled) {
background: var(--bg-hover);
}

.marking-action-btn:disabled {
opacity: 0.4;
cursor: default;
}

.marking-done-btn {
background: var(--accent);
color: #fff;
border-color: var(--accent);
}

.marking-done-btn:hover:not(:disabled) {
filter: brightness(1.1);
background: var(--accent);
}

.marking-image-container {
flex: 1 1 auto;
position: relative;
background: #111;
border-radius: 8px;
overflow: hidden;
display: flex;
align-items: center;
justify-content: center;
/* min-height was 300px which prevented flex-shrink when the parent
(#embryos-marking → .marking-container → .marking-active →
.marking-viewer) lacked a bounded height. Use 0 + a reasonable
basis so the container shrinks correctly inside its flex chain. */
min-height: 0;
}

.marking-image-container img {
max-width: 100%;
max-height: 100%;
object-fit: contain;
}

.marking-image-container canvas {
position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
cursor: crosshair;
pointer-events: auto;
}

/* Marking sidebar */
.marking-sidebar {
width: 220px;
flex-shrink: 0;
display: flex;
flex-direction: column;
background: var(--bg-card);
border: 1px solid var(--border);
border-radius: 8px;
overflow: hidden;
}

.marking-sidebar-header {
padding: 0.6rem 0.75rem;
font-size: 0.85rem;
font-weight: 600;
border-bottom: 1px solid var(--border);
color: var(--text);
}

.marking-list {
flex: 1;
overflow-y: auto;
padding: 0.5rem;
}

.marking-list-empty {
text-align: center;
color: var(--text-muted);
font-size: 0.8rem;
padding: 1.5rem 0.5rem;
}

.marking-list-item {
display: flex;
align-items: center;
gap: 0.5rem;
padding: 0.4rem 0.5rem;
border-radius: 6px;
font-size: 0.8rem;
}

.marking-list-item:hover {
background: var(--bg-hover);
}

.marking-number {
width: 22px;
height: 22px;
Expand All @@ -4096,47 +3915,6 @@ kbd {
font-size: 0.75rem;
}

.marking-remove-btn {
border: none;
background: none;
color: var(--text-muted);
cursor: pointer;
font-size: 1rem;
line-height: 1;
padding: 0 0.2rem;
opacity: 0;
transition: opacity 0.15s;
}

.marking-list-item:hover .marking-remove-btn {
opacity: 1;
}

.marking-remove-btn:hover {
color: #ff6b6b;
}

/* Role chip on each marker — click cycles test ↔ calibration ↔ unassigned.
Inline styles set the role-specific colors (magenta/cyan/grey); this
gives the chip its shape, cursor, and hover affordance. */
.marking-role-chip {
padding: 2px 8px;
border-radius: 10px;
font-size: 0.7rem;
font-weight: 600;
letter-spacing: 0.02em;
cursor: pointer;
user-select: none;
transition: filter 0.15s, transform 0.1s;
flex-shrink: 0;
}
.marking-role-chip:hover {
filter: brightness(1.2) saturate(1.1);
}
.marking-role-chip:active {
transform: scale(0.96);
}

/* Source tag (sam / manual / existing) — quieter than the role chip. */
.marking-source {
font-size: 0.65rem;
Expand Down
48 changes: 48 additions & 0 deletions gently/ui/web/static/css/operate.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,3 +1093,51 @@
opacity: 0.45;
cursor: default;
}

/* ── Agent-initiated marking session ─────────────────────────────────────
Present only while the agent is waiting on an answer, so it seats and
retires with the session rather than standing there empty. */
.mk-session {
margin-top: 8px;
padding-top: 8px;
border-top: 1px solid var(--op-rule);
grid-column: 1 / -1;
}

.mk-shead {
font-size: 0.62rem;
font-weight: 600;
letter-spacing: 0.10em;
text-transform: uppercase;
color: var(--accent);
margin-bottom: 6px;
}

/* One row per pending marker: the contract carries a role for each, so each
needs to be settable before the answer goes back. */
.mk-prow {
display: flex;
align-items: center;
gap: 8px;
padding: 2px 0;
}

.mk-pnum {
flex: 0 0 18px;
font-family: 'SF Mono', Monaco, 'Cascadia Code', monospace;
font-size: 0.72rem;
color: var(--op-ink);
}

.mk-psrc {
flex: 1 1 auto;
font-size: 0.64rem;
color: var(--op-ink-dim);
}

.mk-prole.is-reference {
border-color: var(--accent);
color: var(--accent);
}

.mk-session .mk-acts { margin-top: 8px; }
Loading
Loading