docs: mark what the audit found and what is now fixed - #159
Merged
Conversation
Findings 1, 2, 4, 5, 6, 7 and gently-project#108 are done. The findings stay rather than being deleted, because the reasoning is what stops them coming back — several were subtle enough that only the explanation makes them recognisable again (`subjectIds()`'s fallback could only ever fire in the one case it was wrong for; the roster's action sets differed for no reason either pane justified). What is left needs the microscope, and is named: gently-project#106's beam, gently-project#125's ROI, gently-project#149's per-frame display range, and the two RIG-NOTE constants. PANELS.md gains the Roster panel, and a note that it is the clearest case of rule 1 paying off. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings 1, 2, 4, 5, 6, 7 and #108 are done (#154, #156, #157, #158).
The findings stay rather than being deleted — the reasoning is what stops them coming back. Several were subtle enough that only the explanation makes them recognisable again:
subjectIds()'s fallback could only ever fire in the one case it was wrong for; the roster's two action sets differed for no reason either pane justified.What is left needs the microscope, and is named: #106's beam, #125's ROI, #149's per-frame display range, and the two
RIG-NOTEconstants.PANELS.md gains the Roster panel and a note that it is the clearest case of rule 1 paying off.