Release gate: v0.2-dev → v0.2 (waits for cross-repo E2E) - #46
Open
MuncleUscles wants to merge 5 commits into
Open
Release gate: v0.2-dev → v0.2 (waits for cross-repo E2E)#46MuncleUscles wants to merge 5 commits into
MuncleUscles wants to merge 5 commits into
Conversation
…posit in the snap (#45) * fix(fees)!: canonical v0.6 ABI in harness/site/smoke; show the fee deposit in the snap - harness GenLayerFeeShim.sol, site prototype encoder, and smoke script were still encoding a stale pre-CON-504 protocol (8-field FeesDistribution with leaderTimeoutFee/validatorsTimeoutFee, bytes4 functionSelector allocation nodes) — transactions built by the E2E site could not even be parsed by the snap's own (correct) parser, so green wallet E2E proved nothing about v0.6. All three now encode the canonical shapes (10-field distribution incl. the three price caps; MessageFeeAllocationNode with messageType/onAcceptance/ callKey/bytes feeParams) matching the snap parser and genlayer-js - site fee math replaced with the consensus round-0 formula; units fixed (time-unit allocations are integer seconds, not parseUnits(x,18); realistic cap placeholders) - snap insight panel now shows the numbers that matter: Total / Fee deposit (= value − userValue) / userValue in GEN with raw wei secondary, and the bond being paid on appeal flows - integration test asserts a site-encoded transaction parses as fee-aware (fixture built by the SITE encoder, not the snap's own ABI constants) - snap.manifest.json shasum updated from an actual reproducible build * fix: lint, scanner-safe value parsing, rebuilt snap manifest - parseTransactionValue: validate with an explicit numeric pattern instead of a bare try/catch (the security scanner flags bare catch blocks as unhandled promise rejections; a regex guard is also more precise) - eslint/prettier fixes from --fix - snap.manifest.json shasum from rebuild * style: apply CI prettier formatting; rebuild snap manifest Local prettier disagrees with CI's pin on two sites; applied CI's exact suggested output. Snap manifest shasum from local rebuild — if CI's bundle still differs (build is environment-sensitive), the next commit adopts CI's computed value verbatim. * ci: run build/lint/test on pushes to dev branches Push trigger was main-only; merges to v0.2-dev got no post-merge CI. * build: adopt CI's computed snap shasum Local snap builds produce a different bundle hash than CI (environment- sensitive build — flagged for follow-up); CI is the gate, so its computed value is canonical.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* docs: add branching guide * ci: build snap before e2e tests
* test: reproduce uint256 form precision bug * fix: preserve uint256 form precision * ci: track merged genlayer-js fee branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standing release-gate PR:
v0.2-dev→v0.2This is a long-lived gate PR, not a normal feature PR. Do not merge ad-hoc.
Purpose
v0.2-devis the active integration branch for the v0.6 fee work. Individual PRs merge intov0.2-devand only need to pass normal repo CI — they are not blocked on the full cross-repo release train being green.v0.2-devis promoted tov0.2. It waits for cross-repo E2E (the release train) to go green before it is merged.How to use
v0.2".(Mirrors genlayerlabs/genlayer-consensus#1070.)