Skip to content

feat(genvm): vendor leader public data codec - #1747

Open
kp2pml30 wants to merge 1 commit into
v0.123-devfrom
feat/leader-data-to-genvm
Open

feat(genvm): vendor leader public data codec#1747
kp2pml30 wants to merge 1 commit into
v0.123-devfrom
feat/leader-data-to-genvm

Conversation

@kp2pml30

@kp2pml30 kp2pml30 commented Aug 25, 2026

Copy link
Copy Markdown
Member

Delivery context

Depends-On: genlayerlabs/genvm-manager#29

What

  • Vendors the GenVM LeaderPublicData type and same-as-node byte codec into Studio's Python host
  • Wires opaque leader public data through the manager request and result paths
  • Updates the GenVM pin and existing contract fixtures to the matching Python runner

I plan to make one more PR that will change the encoding, for now it is the same as was in the node before

Why

  • Keeps Studio compatible with the GenVM manager after leader-output encoding ownership moves into the executor
  • Preserves the current encoding and fee behavior

Testing done

  • Existing adapted unit suite passed
  • Existing company-naming and storage integration coverage passed
  • Black, Ruff, and repository pre-commit hooks passed
  • Independent audit confirmed 0 added test files or test functions and no unrelated deletions

Decisions made

  • Vendored the upstream origin implementation directly; Studio-specific address handling remains unchanged
  • Kept decoding explicit through from_bytes rather than constructor behavior

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

Compare backend/node/genvm/origin/leader_public_data.py with the GenVM manager's Python host source, then follow the value through backend/node/genvm/base.py

User facing release notes

No user-facing behavior change; this is a GenVM compatibility update

@kp2pml30 kp2pml30 self-assigned this Aug 25, 2026
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bc5cb48e-cb84-4110-ac46-34a35a402a57

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kp2pml30
kp2pml30 changed the base branch from feat/v02-compat to v0.123-dev August 26, 2026 04:46
@kp2pml30
kp2pml30 force-pushed the feat/leader-data-to-genvm branch from ee7b2fa to e7ae2d7 Compare August 26, 2026 04:57
@kp2pml30
kp2pml30 force-pushed the feat/leader-data-to-genvm branch from e7ae2d7 to d220e51 Compare August 26, 2026 05:49
@kp2pml30
kp2pml30 marked this pull request as ready for review August 26, 2026 06:49
@kp2pml30
kp2pml30 requested a review from MuncleUscles August 27, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants