fix(dotprompt): properly group prompt variants#187
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for prompt variants in the Genkit AI library. Key changes include adding a "variant" field to the Prompt and DotPrompt classes, updating their builders and constructors, and implementing logic to extract variants from prompt names (e.g., "recipe.robot"). The metadata generation for prompts now correctly handles base names and variants. Additionally, unit tests were added for both Prompt and DotPrompt to verify variant handling, and the sample code was updated to demonstrate the new functionality. I have no feedback to provide.
xavidop
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variants were being displayed in Dev UI as their own prompts. This change properly groups them with their parent/base.
Fixes #188