[WIP] chore: fix vulnerabilities - #1309
Conversation
commit: |
✅ Testplane E2E run succeed
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dcac0b76f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const transformed = await swc.transform(bundledScript, { | ||
| jsc: { | ||
| parser: { syntax: "ecmascript" }, | ||
| target: "es5", |
There was a problem hiding this comment.
When Testplane runs against IE8, calibrate.js can select this compatibility bundle, but SWC now only lowers it to ES5. The existing compatibility TypeScript configuration explicitly targets ES3, and the previous uglifyify setup disabled IE8-unsafe transformations; therefore ES5-only syntax emitted here can make screenshot commands fail before execution in the legacy browsers this bundle is intended to support. Retain an ES3/IE8-compatible transformation path or stop routing those browsers to this bundle.
Useful? React with 👍 / 👎.
| "engines": { | ||
| "node": ">=22.12", | ||
| "npm": ">=10" |
There was a problem hiding this comment.
The Android example's README instructs users to run nvm use, but its tracked .nvmrc still selects Node 20 while this new engine declaration requires Node 22.12 or newer. Following the documented setup consequently runs npm ci and the upgraded Testplane/Appium stack on an explicitly unsupported Node version; update .nvmrc alongside this requirement.
Useful? React with 👍 / 👎.
✅ Testplane browser-env run succeed
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42b94165f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "engines": { | ||
| "node": ">=22" | ||
| } |
There was a problem hiding this comment.
The Android occurrence is already noted, but the Storybook example independently has the same mismatch: its README explicitly tells users to run nvm use, while its tracked .nvmrc selects Node 20.10 and this new declaration requires Node 22 or newer. Following the documented installation steps therefore runs the upgraded Storybook/Testplane stack on an unsupported Node release; update this example's .nvmrc alongside the engine requirement.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 941596fea9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "engines": { | ||
| "node": ">=22" |
There was a problem hiding this comment.
The Android and Storybook occurrences are already noted, but this example independently retains a tracked .nvmrc containing 20 while the new engine declaration requires Node 22 or newer. Running nvm use in this example therefore selects an explicitly unsupported runtime for the upgraded Testplane/Vite stack; update .nvmrc with the engine requirement.
Useful? React with 👍 / 👎.
| "engines": { | ||
| "node": ">=22" |
There was a problem hiding this comment.
This example's tracked .nvmrc still selects Node 20, but the newly added engine declaration requires Node 22 or newer. Anyone using the repository's version selector in this directory will install and run the upgraded Testplane/Vite dependencies on an explicitly unsupported runtime; update .nvmrc alongside this requirement.
Useful? React with 👍 / 👎.
| "engines": { | ||
| "node": ">=22" |
There was a problem hiding this comment.
The drag-and-drop example also retains a tracked .nvmrc containing 20 while this new engine declaration requires Node 22 or newer. Running nvm use in the example selects an unsupported runtime for the upgraded Testplane dependencies, so the version selector should be updated with the engine requirement.
Useful? React with 👍 / 👎.
1 participant
No description provided.