fix(selectivity): script id matching on page change - #1290
Merged
Conversation
Member
Author
|
@codex review |
✅ Testplane E2E run succeed
|
commit: |
✅ Testplane browser-env run succeed
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17c04a78af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
KuznetsovRoman
commented
Jul 13, 2026
| * Must run while the "scriptId -> source" maps still describe the scripts the coverage was taken from | ||
| * (i.e. before the page is navigated away and the maps are cleared). | ||
| */ | ||
| private async _resolveCoverageToDeps(coverageScripts: CDPScriptCoverage[]): Promise<void> { |
Member
Author
There was a problem hiding this comment.
Pulled from L286 - L352
|
|
||
| this._ensureScriptsAreLoading(coverageLastPart.result); | ||
|
|
||
| const totalDependingSourceFiles = new Set<string>(); |
Member
Author
There was a problem hiding this comment.
Moved to _resolveCoverageToDeps method
| const testplaneCoverageBreakScriptName = "__testplane_cdp_coverage_snapshot_pause"; | ||
| const scriptToEvaluateOnNewDocument = `window.addEventListener("beforeunload", function ${testplaneCoverageBreakScriptName}() {debugger;});`; | ||
| const scriptToEvaluateOnNewDocument = [ | ||
| "if (window.top === window) {", |
sonic16x
approved these changes
Jul 20, 2026
KuznetsovRoman
force-pushed
the
TESTPLANE-1061
branch
from
July 29, 2026 01:28
17c04a7 to
0101f44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JS selectivity dependency collection when CDP reuses scriptId values across page navigations.