[WIP] chore: fix vulnerabilities - #796
Conversation
💡 Codex ReviewLine 284 in 18cae13  Pin tools compatible with the configured Node range
The checked html-reporter/package-lock.json Lines 24333 to 24335 in 18cae13  Restore integrity metadata in the lockfile
The regenerated lockfile drops ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
18cae13 to
c475a34
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c475a344d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| "engines": { | ||
| "node": ">= 18" | ||
| "node": ">= 22.22.0" |
There was a problem hiding this comment.
Raising the package engine to Node 22.22 makes installations fail for users with engine-strict on Node 18 or 20, even though those versions were supported immediately before this commit and all production dependencies in this lockfile still support Node 18. It also conflicts with the unchanged CI matrix in .github/workflows/node.js.yml, which runs npm ci and tests on Node 18, 20, and 22.6 and builds/publishes on Node 20, as well as the Node 20 e2e workflow. Retain the prior runtime compatibility by selecting compatible development dependencies, or update the release policy and every affected workflow as an intentional breaking change.
Useful? React with 👍 / 👎.
c475a34 to
df7a4ca
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df7a4ca0e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| return runner.run((collection) => | ||
| this._tool.run(collection, {grep, sets, tag, browsers, inspectMode, devtools, replMode, local, requireModules}) | ||
| this._tool.run(collection, {grep, sets, tag, browsers, inspectMode, replMode, local, requireModules}) |
There was a problem hiding this comment.
When the GUI is invoked with Testplane's --devtools option, cliTool.devtools still reaches this adapter, but the updated call silently drops it, so the selected tests run without the requested DevTools mode. This also regresses Testplane 8 installations, which remain supported by the unchanged testplane: "*" peer range; the prior unit test explicitly verified that this option was forwarded. Keep passing devtools (extra run options are harmless to versions that do not use them), or narrow the supported Testplane range and reject the obsolete CLI option explicitly.
Useful? React with 👍 / 👎.
7637600 to
73d0003
Compare
✅ Component tests succeed
|
commit: |
❌ E2E tests failed
|
faaa69b to
7a4c930
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a4c93079e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 22.6] # https://github.com/nodejs/node/issues/54532 | ||
| node-version: [20.x, 22.x, 24.x] |
There was a problem hiding this comment.
The fresh evidence in the current tree is that this matrix was updated but still retains 20.x, while the same change declares Node >=22.22.0 and locks react-router@8.3.0, which has that same minimum; moreover, the Build and Publish steps at lines 31–36 run exclusively for this unsupported Node 20 job. The unchanged e2e workflow also installs and builds on Node 20, so CI continues exercising the upgraded toolchain outside its supported runtime; move these build/publish conditions and the e2e job to at least Node 22.22.
Useful? React with 👍 / 👎.
7a4c930 to
c45220b
Compare
c45220b to
8168a67
Compare
1 participant
No description provided.