Add trust workspace env for skill activation test.#172
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the GEMINI_CLI_TRUST_WORKSPACE environment variable to the eval.google-cicd-deploy.yaml and eval.google-cicd-pipeline-design.yaml configuration files. The feedback suggests quoting the boolean value "true" to ensure it is correctly interpreted as a string by YAML parsers, preventing potential unmarshaling errors when these values are used as environment variables.
| base: cicd-evals:latest | ||
| env: | ||
| GOOGLE_APPLICATION_CREDENTIALS: ~/.config/gcloud/application_default_credentials.json | ||
| GEMINI_CLI_TRUST_WORKSPACE: true |
There was a problem hiding this comment.
In YAML, the value true is interpreted as a boolean. Environment variables are typically expected to be strings. Some YAML parsers will fail to unmarshal a boolean value into a string field, which can lead to configuration errors. It is recommended to wrap the value in quotes to ensure it is treated as a string.
GEMINI_CLI_TRUST_WORKSPACE: "true"| base: cicd-evals:latest | ||
| env: | ||
| GOOGLE_APPLICATION_CREDENTIALS: ~/.config/gcloud/application_default_credentials.json | ||
| GEMINI_CLI_TRUST_WORKSPACE: true |
There was a problem hiding this comment.
In YAML, the value true is interpreted as a boolean. Environment variables are typically expected to be strings. Some YAML parsers will fail to unmarshal a boolean value into a string field, which can lead to configuration errors. It is recommended to wrap the value in quotes to ensure it is treated as a string.
GEMINI_CLI_TRUST_WORKSPACE: "true"1 participant
No description provided.