Skip to content

fix(sv): stop counting reference-genotyped and noisy calls as a second SV caller - #284

Open
geiresx wants to merge 6 commits into
mainfrom
pgp/i411-sv-consensus-input
Open

geiresx wants to merge 6 commits into
mainfrom
pgp/i411-sv-consensus-input

Conversation

@geiresx

@geiresx geiresx commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Step 22 handed SURVIVOR every PASS record, so a Delly record genotyped
0/0, a Delly call whose sample filter says LowQual, or a CNVpytor
segment no quality rule had read counted as a second caller.

The new verb drops a record whose FILTER or first-sample FT is not PASS,
or whose genotype calls an allele but no ALT (0/0, 0|0, 0, 0/.). A
no-call and a sites-only record keep their vote. For CNVpytor it applies
the e-value and MAPQ 0 rule of og sv add-callers, now shared constants.

Bead: sv-05
Bead: sv-06
Bead: D14
The script and the Nextflow SURVIVOR_PREP each carried the same
bcftools view -f PASS,. and awk. Both now call og sv survivor-prep, so
a 0/0 or FT=LowQual Delly record and a CNVpytor call below its quality
rule no longer reach SURVIVOR. The VCF step 22 makes from CNVpytor's
table carries the table's e-value, q0 and pN under CNVpytor's INFO
names, so the same rule reads both inputs.

Bead: sv-05
Bead: sv-06
Bead: sv-40
Bead: D14
Step 18 and its doc told the reader to keep calls with e-value below
0.05 and size over 1 kb, while steps 05 and 22 use e-value below 0.01
and q0 below 0.5. The hint and the doc now give that one rule.

Bead: sv-09
Bead: sv-10
Bead: sv-11
Three Manta-only deletions in the step 22 fixtures sit beside a Delly
0/0 record, a Delly FT=LowQual call and a CNVpytor segment with e-value
0.5. Main's prep made each read as two callers (4 consensus records
instead of 1). The new e2e case sv-merge-votes checks them, a ./.
CNVpytor call that still votes, and the same calls from CNVpytor's
table. Step 22 now runs og, so its existing case lists bin/og and the
scope test counts it among the cases a Rust change runs.

Bead: sv-05
Bead: sv-06
Bead: sv-40
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…he e-value

An earlier step 22 wrote cnvpytor/<sample>_cnvs.vcf.gz from CNVpytor's
table without pytorP1 and pytorQ0, and a rerun reused it, so none of
its calls would vote. When the table is there and that VCF's header
does not declare pytorP1, the step makes the VCF again. Step 18's own
VCF declares it and is kept. The e2e case strips the tags and checks
the rerun.

Bead: sv-40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants