Repository navigation
Conversation
Step 50 now writes "call filtered out (FLAGS)" for a catalog site whose only calls MEGAnE flagged. The note under the MEI section explained "not callable" and "not seen" only. Both renderers now add one sentence: MEGAnE called an insertion there but flagged it, so it is not a finding, and not proof of absence either. The Python and Rust notes stay the same, byte for byte. Bead: sv-34
… did not Two mei-report cases put a call MEGAnE flagged LC inside the FKTN window: alone (og: call filtered out (LC); bin/mei_report.py: seen), and before a PASS call in the same window (og names the PASS call; the oracle named the first). Each has a golden s.tsv, so the harness fails if og goes back to the oracle's reading, and fails as stale if the golden is changed back to what the oracle writes. The calls table is the same on both sides. Bead: sv-34
… note The MEI note changed in both renderers in dd9290f. The report-render oracle was render_report.py at 65095e9, which still had the old note, so 28 cases would differ from og only by that sentence. The oracle and the modules it imports now come from dd9290f, where the Python and Rust notes are the same: every report-render case still compares byte for byte. Bead: sv-34
The MEI note must name every status a catalog row can have, and both reports must show a "call filtered out (LC)" row with the sentence that explains it. Red on the note before dd9290f: both tests failed. Bead: sv-34
…e listed The overview table and the design brief listed seen, not seen and not callable only. docs/50-mei.md now says what the report note explains and names the new parity cases and test. The changelog says what changed in the reports and why not callable keeps its name. Bead: sv-34
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeiserX#541