Repository navigation
Conversation
…ow that og marks partial tests/test_write_manifest.sh now checks that INTERVALS set writes one run intervals row and unset or blank writes none, then reads that manifest with og summary collect beside a VCF on all 22 autosomes and expects the partial mark. Red on main: no step writes the row. Bead: D14
…s partial bin/write_manifest.sh writes run intervals from INTERVALS, and the Nextflow HTML_REPORT writes the same row from --intervals, so the scope check og summary collect already does (GeiserX#515) sees a run limited to intervals. No row for a whole-genome run. The CHANGELOG entry and the quality guide no longer say the row is never written. Bead: D14
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
… --intervals Section 5 of tests/test_write_manifest.sh runs the intervals lines of HTML_REPORT's task script in bash, with the value its def would hand them, and checks they write the row write_manifest.sh writes, and no row without --intervals. Red control: the module without the printf line does not write the row. Main's module fails 3 of these checks. Bead: D14
INTERVALS is shared with step 29, where genome means the whole genome and chip the CHIP genes. With either exported, a hand-run report marked a whole-genome run partial. write_manifest.sh now writes no row for them. HTML_REPORT puts --intervals on one line in its task script, as write_manifest.sh does, and its def only quotes the value. The test now evaluates that def and runs the task lines with a tab, a newline and a quote in the value, with red controls for each step. Bead: D14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeiserX#540