Skip to content

fix(scope): record the --intervals a run used so its report says it is partial - #282

Open
geiresx wants to merge 4 commits into
mainfrom
pgp/i411-run-scope-intervals-row
Open

geiresx wants to merge 4 commits into
mainfrom
pgp/i411-run-scope-intervals-row

Conversation

@geiresx

@geiresx geiresx commented Nov 20, 2026

Copy link
Copy Markdown
Owner

…ow that og marks partial

tests/test_write_manifest.sh now checks that INTERVALS set writes one
run intervals row and unset or blank writes none, then reads that
manifest with og summary collect beside a VCF on all 22 autosomes and
expects the partial mark. Red on main: no step writes the row.

Bead: D14
…s partial

bin/write_manifest.sh writes run intervals from INTERVALS, and the
Nextflow HTML_REPORT writes the same row from --intervals, so the scope
check og summary collect already does (GeiserX#515) sees a run limited to
intervals. No row for a whole-genome run. The CHANGELOG entry and the
quality guide no longer say the row is never written.

Bead: D14
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

… --intervals

Section 5 of tests/test_write_manifest.sh runs the intervals lines of
HTML_REPORT's task script in bash, with the value its def would hand
them, and checks they write the row write_manifest.sh writes, and no row
without --intervals. Red control: the module without the printf line
does not write the row. Main's module fails 3 of these checks.

Bead: D14
INTERVALS is shared with step 29, where genome means the whole genome and
chip the CHIP genes. With either exported, a hand-run report marked a
whole-genome run partial. write_manifest.sh now writes no row for them.

HTML_REPORT puts --intervals on one line in its task script, as
write_manifest.sh does, and its def only quotes the value. The test now
evaluates that def and runs the task lines with a tab, a newline and a
quote in the value, with red controls for each step.

Bead: D14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants