Skip to content

feat(run): add EVERYTHING=true so the owner's runs never miss an optional step - #280

Open
geiresx wants to merge 5 commits into
mainfrom
pgp/screen-everything-switch
Open

geiresx wants to merge 5 commits into
mainfrom
pgp/screen-everything-switch

Conversation

@geiresx

@geiresx geiresx commented Nov 20, 2026

Copy link
Copy Markdown
Owner

… script 04a

EVERYTHING=true reads assets/everything.tsv: every tool row goes into TOOLS
(html_report aside: run-all.sh writes the report itself), every switch row
is set to its value, and TOOLS or a switch set to another value stops the run
with exit 2. A step skipped because its data is not installed, or because a
panel is set to none, stops the run with exit 2 before Nextflow and names the
setup command. Skips that come from the sample stay skips: no BAM, no gVCF,
a female sample for steps 37 and 45, a BAM that is not PacBio HiFi for 35b.

Step 37 on a female sample is now listed as skipped, as step 45 was; the
pipeline skipped it already. Step 35b runs og paraphase check-bam on the BAM
first, so a BAM that is not PL:PACBIO, or a FASTQ row, is a skip instead of a
failed step.

TIDDIT=true runs 04a-tiddit.sh after the pipeline, so every optional step is
reachable from one command. EVERYTHING and TIDDIT join SWITCHES, the replay
list of og recheck, the output contract, and step 04a joins assets/steps.tsv
and RUN_ALL_STEPS, which the tests keep equal to what run-all.sh records.

Bead: D8
assets/everything.tsv lists every optional item: each --tools name of
main.nf, each run-all.sh switch, each setup.sh flag, each false-by-default or
opt-in parameter of nextflow.config and each optional image of versions.env,
as tool, switch, setup, input, image or excluded with the reason.
og dev everything-check fails when one of them has no row, when a row names
an item that is gone, when conf/everything.config sets other tools or
parameters than the rows, or when conf/test_all.config misses a tool. Guard
runs it; its planted cases are og-dev unit tests.

-profile everything (conf/everything.config) gives the Nextflow path the same
tools and switches as EVERYTHING=true.

Bead: D8
Every data folder stubbed: every tool row runs and every script step runs
after the pipeline. Without Yleaf's tables it exits 2 before Nextflow and
names setup.sh --yleaf-data. A female sample still runs with the Y steps
skipped; a BAM that is not PacBio HiFi skips Paraphase. TOOLS, KIR=false or
ARCHAIC_DIR=none with EVERYTHING=true are refused.

Bead: D8
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…index

GRIDSS (script 04b, after the pipeline) needs the classic BWA index, which
setup.sh does not build; an EVERYTHING=true run now refuses up front instead
of failing hours in. A refused run puts the last run's run_status.tsv back
and posts no run-finished event. pipeline-overview.md lists TIDDIT=true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants