Repository navigation
feat(acmg): screen secondary findings on every run with ClinVar, not only runs with the VEP cache - #275
Closed
geiresx wants to merge 9 commits into
Closed
feat(acmg): screen secondary findings on every run with ClinVar, not only runs with the VEP cache#275geiresx wants to merge 9 commits into
geiresx wants to merge 9 commits into
Conversation
Red first: summary.json has no ACMG card when clinical/ is missing, and the agreement test compares every group b parity folder with and without its clinical VCF. summary-clinical.sh gets NO_ORACLE=1 so the test can write the folders without the oracle's helper modules. Bead: D11 Bead: D14
… step 06 sections.acmg_sf follows step 06: ok when the ClinVar hits VCF is there, not run or failed with step 06's reason otherwise. The verdicts come from the same acmg::acmg_sf the clinical section calls. Without step 23's clinical VCF the card says high_impact_checked false and high_impact_note names why and what it can miss; an unreadable clinical VCF costs only the HIGH-impact source. The clinical section keeps its nested card for the readers that still use it. The full-summary parity goldens gain the section. Bead: D11 Bead: D14
… in e2e acmg-sf-rules-1-reports gains a cell without clinical/: the card is there with the 84 rules, says the HIGH-impact source was not screened and keeps every ClinVar row of the full run's card. nf-wiring-1-report-tables compares the card of the bash and the Nextflow summaries. Bead: D11 Bead: D14
Bead: D11
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
…dings card When step 23 is not ok in this run and its clinical VCF predates the run, sections.acmg_sf still reads that VCF. The card now says so in high_impact_note, with the VCF's date and step 23's result, as the clinical section goes stale.
… keep it out of the search index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeiserX#533