Skip to content

feat(acmg): screen secondary findings on every run with ClinVar, not only runs with the VEP cache - #275

Closed
geiresx wants to merge 9 commits into
mainfrom
pgp/screen-acmg-card-section
Closed

geiresx wants to merge 9 commits into
mainfrom
pgp/screen-acmg-card-section

Conversation

@geiresx

@geiresx geiresx commented Nov 20, 2026

Copy link
Copy Markdown
Owner

Red first: summary.json has no ACMG card when clinical/ is missing, and
the agreement test compares every group b parity folder with and without
its clinical VCF. summary-clinical.sh gets NO_ORACLE=1 so the test can
write the folders without the oracle's helper modules.

Bead: D11
Bead: D14
… step 06

sections.acmg_sf follows step 06: ok when the ClinVar hits VCF is there,
not run or failed with step 06's reason otherwise. The verdicts come from
the same acmg::acmg_sf the clinical section calls. Without step 23's
clinical VCF the card says high_impact_checked false and high_impact_note
names why and what it can miss; an unreadable clinical VCF costs only the
HIGH-impact source. The clinical section keeps its nested card for the
readers that still use it. The full-summary parity goldens gain the
section.

Bead: D11
Bead: D14
… in e2e

acmg-sf-rules-1-reports gains a cell without clinical/: the card is
there with the 84 rules, says the HIGH-impact source was not screened and
keeps every ClinVar row of the full run's card. nf-wiring-1-report-tables
compares the card of the bash and the Nextflow summaries.

Bead: D11
Bead: D14
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…dings card

When step 23 is not ok in this run and its clinical VCF predates the run,
sections.acmg_sf still reads that VCF. The card now says so in
high_impact_note, with the VCF's date and step 23's result, as the clinical
section goes stale.
@geiresx geiresx closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants