Skip to content

fix(bloodtype): lower confidence for weak calls and stop reading a missing chr9 as type O - #274

Closed
geiresx wants to merge 7 commits into
mainfrom
pgp/i411-bloodtype-call-floor
Closed

geiresx wants to merge 7 commits into
mainfrom
pgp/i411-bloodtype-call-floor

Conversation

@geiresx

@geiresx geiresx commented Nov 19, 2026

Copy link
Copy Markdown
Owner

… phase

A present genotype was used whatever its quality. The reader now marks a
call with GQ under 20 or DP (else MIN_DP) under 8 as weak, keeping its
genotype, and keeps the haplotype of the marker's ALT and the phase set
of a phased call, for the rules to use.

Bead: trait-31
Bead: D10
…ssing chr9 as type O

A weak call gives its system confidence low and is named in the note.
Without a BAM, a system with no VCF record at any of its sites reads not
assessed instead of the reference phenotype at confidence medium. Duffy
places a GATA box phased with one Fyb on the chromosome the VCF gives. An
ABO A allele reads low, since no variant shows it. The ABO, RhD and
null-row notes say what the DNA cannot check. The bloodtype parity
goldens record these changes on purpose.

Bead: trait-31
Bead: trait-28
Bead: trait-32
Bead: trait-33
Bead: trait-35
Bead: trait-36
Bead: trait-37
Bead: D10
… and fix the position count

The step page, the script and module headers, the VCF-only page and the
e2e case now match the new rules. The crate doc said the VCF is read at
318 positions; the marker table has 271.

Bead: trait-39
Bead: trait-33
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…s a reference call

A reference block that starts before a marker and covers it through
INFO/END was ignored, so without a BAM a gVCF could read a system as not
assessed although it covers it. Such a block is now a reference call at
the marker, with its GQ and MIN_DP. ABO's c.796C>A call now counts in
the ABO confidence and notes, and the VCF-only page says the blood
groups are opt-in.

Bead: trait-28
Bead: D10
…ssed systems and new RhD notes

Without a BAM, the platelet case's control VCF had no record at the
HPA-1, HNA-3 and HNA-4 sites, which now read not assessed; it now plants
0/0 there. The copy-number case compared step 41's whole RhD row with
the tree before the engine, notes included; it now compares the
phenotype, genotype and confidence, the engine's result.

Bead: trait-28
Bead: trait-35
…ll-floor

# Conflicts:
#	CHANGELOG.md
#	tests/e2e/cn-engine-1-parity.sh
…off an unread ABO row

Also correct the gVCF block wording (DP, else MIN_DP) and the platelet
control label.
@geiresx geiresx closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants