Skip to content

review only: og-reports, seven opt-in step reports (upstream #386) - #118

Closed
geiresx wants to merge 1 commit into
pgp/review-rust-p2-basefrom
pgp/review-rust-p2-src
Closed

geiresx wants to merge 1 commit into
pgp/review-rust-p2-basefrom
pgp/review-rust-p2-src

Conversation

@geiresx

@geiresx geiresx commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Review-only PR. It holds the source of GeiserX#386 at 00b480d, without the parity inputs and goldens, so that the review fits under the 100-file limit. The base is main plus those data files. Do not merge. Findings go to the upstream PR.

Summary by CodeRabbit

  • New Features
    • Added bundled reporting commands for Y-STR, viral, Exomiser, MEI, MoChA, VNtyper, and LoCiTyper workflows. These generate their reports and, where applicable, prepare analysis inputs.
  • Documentation
    • Updated workflow guides and command references to describe the reporting tools and their outputs.
    • Added notes on report behavior, validation, and platform requirements.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

The PR adds Rust report commands for seven tools, wires them into og, and replaces Python report-script calls in workflows and tests. It also updates report documentation, demo output generation, CI checks, and parity mappings.

Changes: Rust report command migration

Layer / File(s) Summary
Shared reporting crate and CLI wiring
.github/workflows/*, CHANGELOG.md, rust/Cargo.toml, rust/crates/og-reports/*, rust/og/*, docs/rust.md, scripts/ci/oracle-diff.sh, tests/parity/oracle.ref
Adds the og-reports crate and shared file, TSV, error, and output helpers. Adds report command dispatch and CI and parity checks.
Exomiser preparation and reporting
rust/crates/og-reports/src/exomiser.rs, bin/exomiser_report.py, modules/local/exomiser/main.nf, scripts/48-exomiser.sh, docs/48-exomiser.md, tests/test_exomiser_report.py, tests/e2e/exomiser-1.sh, tests/demo/make_demo_sample.py, bin/collect_summary.py
Adds HPO validation, analysis preparation, optional family PED generation, and TSV and text reporting. Replaces the Python command in the Exomiser workflow and tests.
MEI reporting and AnnotSV input
rust/crates/og-reports/src/mei.rs, bin/mei_report.py, modules/local/mei/main.nf, scripts/50-mei.sh, docs/50-mei.md, tests/test_mei_report.py, tests/e2e/mei-1.sh, tests/demo/make_demo_sample.py, bin/collect_summary.py
Adds MEI call and catalog reports plus AnnotSV input generation. Replaces the Python command in the MEI workflow and tests.
MoChA and viral reports
rust/crates/og-reports/src/{mocha,viral}.rs, bin/{mocha,viral}_report.py, modules/local/{mocha,viral}/main.nf, scripts/{47-viral,51-mocha}.sh, docs/{47-viral,51-mocha}.md, tests/test_{mocha,viral}_report.py, tests/test_report_charts.py, tests/demo/make_demo_sample.py, bin/collect_summary.py
Adds MoChA call and sample assessment reports and viral coverage classification. Switches their workflows and report tests to og commands.
VNtyper and Locityper reports
rust/crates/og-reports/src/{vntyper,locityper}.rs, bin/{vntyper,locityper}_report.py, modules/local/{vntyper,locityper}/main.nf, scripts/{52-vntyper,53-locityper}.sh, docs/{52-vntyper,53-locityper}.md, tests/test_{vntyper,locityper}_report.py, tests/e2e/ci-e2e-2-locityper.sh, tests/smoke/{vntyper,locityper}.sh, tests/demo/make_demo_sample.py, bin/collect_summary.py
Adds VNtyper result interpretation and Locityper per-locus filtering reports. Updates the associated workflows, tests, and demo generation to use the Rust commands.
Y-STR panel and reports
rust/crates/og-reports/src/ystr.rs, bin/ystr_report.py, modules/local/y_str/main.nf, scripts/45-y-str.sh, docs/45-y-str.md, tests/test_ystr_report.py, tests/e2e/y-str-1.sh, tests/smoke/hipstr.sh, tests/demo/make_demo_sample.py, bin/collect_summary.py
Adds panel validation, BED generation, and TSV/CSV reporting. Replaces the Python commands in the Y-STR workflow and tests.

Estimated code review effort: 5 (Critical) | ~120 minutes

Change: Refactor

Possibly related PRs

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@geiresx

geiresx commented Nov 11, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Action not completed

Pull request is closed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@geiresx geiresx closed this Nov 11, 2026
@geiresx
geiresx deleted the pgp/review-rust-p2-src branch November 11, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants