v1.68.0.0 fix: next tracker wave — 16 verified fixes in, 90 stale PRs and 21 issues closed with receipts - #2632
Merged
Merged
Conversation
--check already ignored those prefs; --write still stored them and --stats counted them as a working NEVER_ASK. Refuse the write and count leftover on-disk prefs as INERT_ONE_WAY. Co-authored-by: Cursor <cursoragent@cursor.com>
…efault
Skill preambles read configuration with
VAR=$(gstack-config get <key> 2>/dev/null || echo "<default>")
and that fallback only fires on a non-zero exit. lookup_default ended in a
catch-all that echoed "" and returned 0, so for any key missing from the table
VAR came back empty and the default written right there in the preamble was
unreachable. The skill then branched on a value it never specified: "skip
entirely if QUESTION_TUNING is false", reached with QUESTION_TUNING="".
Four keys that skills actually read had no entry and took that path:
question_tuning -> callers assume "false"
repo_mode -> callers assume "unknown"
team_mode -> callers assume "false"
transcript_ingest_mode -> callers assume "off"
Each default above is the value the call sites already substitute in their own
`|| echo` fallback, so this only makes reachable what was already intended.
The catch-all now returns non-zero. That is deliberately scoped to the
unknown-key arm alone: keys whose default is intentionally empty still exit 0,
because "" is their real answer and their callers depend on it --
cross_project_learnings ("unset triggers the first-time prompt"),
redact_repo_visibility ("empty falls through to gh/glab detection"),
salience_allowlist, user_slug_at_*. Making every empty answer an error would
have broken those.
test/gstack-config-defaults.test.ts pins the class rather than the four
instances: it parses the case arms and asserts every `gstack-config get <key>`
site in the tree is covered, so adding a read without a default fails CI. It
also pins the exit-code contract in both directions. Verified failing against
the pre-fix script, where it names exactly those four keys.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
main() recognised exactly two subcommands and let everything else fall through
to the stdin scan. On empty stdin that prints "(no findings)" and exits 0, so:
$ gstack-redact install-prepush-hooks # plural typo
gstack-redact scan — repo UNKNOWN
(no findings)
$ echo $?
0
No hook was installed, and the operator has every reason to believe the
credential guard is armed. A guard that silently no-ops must never exit 0.
Two smaller faults in the same dispatch, both of which lead people here:
- There was no --help handler, so `gstack-redact --help` fell through to the
scanner. Piping a credential to it scanned the secret and exited 3.
- With no piped input and no --from-file, readInput() blocks on readSync(fd 0)
until an EOF that an interactive terminal never sends. That prints nothing
at all, so it reads as a hang rather than as "this is a filter, feed it".
Now: --help/-h/help prints usage and exits 0; an unrecognised positional
prints the offender and exits 1; a TTY with nothing piped in prints usage
instead of blocking. "scan" stays accepted, because the human output header
reads "gstack-redact scan — repo …" and that is what people type.
Usage errors exit 1, deliberately not 2 or 3. Those mean MEDIUM and HIGH
findings and callers gate dispatch on them, so a usage error exiting 2 would
be read as "medium findings — prompt the user". A test pins that.
Tests: 4 written failing first, then fixed. Full suite 7,722 pass / 0 fail.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…reenshot
`snapshot -a` exits 1 with "Selector matched multiple elements" on most real
pages, so /qa, /canary and /land-and-deploy silently produce reports whose
screenshots do not exist. Plain `screenshot <path>` is unaffected.
Refs are built as getByRole(role, {name}) and disambiguated with .nth() when
role+name repeats. That disambiguation cannot fire for a node with NO accessible
name: the locator degrades to getByRole(role) with no name filter, and the count
driving .nth() is taken from the FILTERED aria snapshot while getByRole matches
the unfiltered DOM. Measured on a live page: the tree surfaced 2 unnamed
paragraphs, the DOM had 9. Landmarks (banner/main/contentinfo) and paragraphs are
correctly unnamed per ARIA, so this is the common case rather than an edge case.
boundingBox() then hits Playwright strict mode, and the catch allowlisted only
timeout/closed/Target/Execution-context messages — so the strict-mode error was
re-thrown and aborted every remaining annotation.
Two changes:
- `.first()` before boundingBox(), so an ambiguous ref draws a box on its first
match instead of aborting. The heatmap path below has always tolerated this via
a bare `catch {}`; annotate was the only path that could be killed outright.
- the catch no longer re-throws on unrecognised messages. A box we cannot measure
is a box we do not draw, never a reason to lose the rest of the page. Set
BROWSE_DEBUG to see what was skipped.
Also: `-o` passed without `-a`/`-H` was silently ignored (exit 0, no file), which
reads as "screenshots are broken" rather than "you forgot a flag". It now warns
and points at `browse screenshot <path>`.
Verified by rebuilding both ways against the same page with 51 refs present:
before — "Selector matched multiple elements", no file written
after — exit 0, 229KB PNG
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…cated 0.0.0.0 into package.json
repair now fails with exit 2 when the VERSION file is absent or empty
instead of folding to DEFAULT ("0.0.0.0") — which passed VERSION_RE and
regressed package.json below where it started. classify gains an additive
versionFileExists field so /ship can tell a real 0.0.0.0 from a fabricated
one. Re-derived from PR #2612 under the generated-file screening rule.
Fixes #2600 (repair half; the path-configurability half landed in v1.67 via #2531).
Contributed by @Lockyer228
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… gate --bulk uses probeMode previously stat'd every walked file, so setup-gbrain gated its silent bulk ingest on pre-filter counts that the write path would never ingest (#2394). The attribution decision now lives in ONE shared gate (sessionIsAttributable — cheap-parse: cwd extraction + memoized resolveGitRemote, never a full page build) used by BOTH probeMode and preparePages, so the two stages' post-attribution counts are structurally identical. ProbeReport gains skipped_unattributed; the probe prints what it excluded and --include-unattributed restores raw counts. The parity is pinned at the prepare stage (probe post-attribution == transcripts reaching import), deliberately NOT == final written. Re-derived from PR #2612 under the generated-file screening rule; the shared-gate design and the remote memo are additions from the plan review. Fixes #2394. Contributed by @Lockyer228 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ement
Adds Emulation.setCPUThrottlingRate and Network.emulateNetworkConditions to
CDP_ALLOWLIST.
Motivation: diagnosing a real "uploads take 1-2 minutes" report, the only
machine available was a fast developer workstation. Client-side processing
measured 1.4s where the user experienced minutes, so the conclusion had to be
reached arithmetically rather than observed. Throttling would have let the
measurement reproduce the reporter's conditions directly.
Both fit the existing posture rather than widening it:
- Emulation already allows setDeviceMetricsOverride, clearDeviceMetricsOverride
and setUserAgentOverride, which are equally mutating and scoped to the tab.
- Neither method reads page content. setCPUThrottlingRate affects only timing;
emulateNetworkConditions constrains traffic rather than inspecting it, so no
request bodies, headers or cookies are exposed. Both are output: 'trusted'
because they return no page-derived data.
scope 'tab' for both, matching the surrounding Emulation entries.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ounds every wedge (#2613) echo $$ inside the backgrounded subshell recorded the PARENT hook's PID — which exits immediately — so every subsequent session judged the lock stale and rm -rf'd a LIVE holder's lock, letting concurrent updaters run over each other. The pidfile now records ${BASHPID:-$(sh -c 'echo $PPID')} (macOS bash 3.2 has no BASHPID; the sh child's PPID is exactly this subshell). Staleness is now two independent detectors: PID liveness (as before, but against the real holder), and a 30-minute hard TTL on the heartbeat mtime — reclaimed regardless of kill -0, so a recycled PID or hung holder can't wedge the lock forever. The holder touches the pidfile after the pull and after setup, so a legitimately-slow run keeps itself alive. Empty and missing pidfiles are respected inside the TTL window (the mkdir→echo race) and reclaimed past it. Fixes #2613. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tripwire (#2575 residual) Bun.spawn sites were structurally outside the windowsHide census (it swept child_process bindings only). The runtime was already safe — native Bun hides consoles by default and bun-polyfill.cjs defaults windowsHide !== false since #2523/#2539 — but implicit defaults are exactly what regress silently. Every Bun.spawn/spawnSync in browse/src now carries the explicit flag (harmless on unix-only sites like Xvfb/xattr/open), and a second SWEEP in windows-spawn-hide.test.ts fails CI on any new flagless Bun.spawn site. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ntly stale brains (#2516) The daily pull refreshed only ~/.gstack itself, never the detached worktree at ~/.gstack-brain-worktree that gbrain actually indexes — so after setup the brain served stale pages forever unless setup-gbrain/sync-gbrain happened to run. brain-sync --once now advances the worktree once per 24h behind an ATTEMPT stamp (.brain-worktree-last-advance — a persistently-failing advance warns once a day, not at every skill boundary), inside the existing run lock and before any ingest step touches the worktree. The new gstack-gbrain-source-wireup --advance-only is built for the unattended cadence: git-only (no gbrain prereqs), pins every operation to the managed worktree (refuses paths that are not worktrees of the artifacts repo), refuses dirty worktrees, and never runs the force-remove recovery — a cron path must not be able to delete local changes. A static pin keeps the force-remove out. docs/gbrain-sync.md stops overclaiming the old cadence. Fixes #2516. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…#2392) Transcript ingest now respects the same trust store as code import — the gate existed only in gstack-gbrain-sync's runCodeImport, so memory-ingest happily ingested transcripts from deny-listed repos. preparePages filters prepared transcript pages through ONE batch policy lookup (new 'get --batch' verb on bin/gstack-gbrain-repo-policy — the script owns URL normalization; the client adds repoPolicyTierBatch, one spawn for all distinct remotes, so large corpora never pay a 10s-timeout subprocess per remote). Outcomes match code-import semantics: read-only → clean skip (skipped_policy_readonly), deny → counted refusal (skipped_policy_deny), corrupted/unreadable store → HARD ERROR before any write (state, staging, egress receipt, and import all untouched) with the recovery command named — policy corruption must never read as successful ingestion. Artifacts are never policy-filtered (their git_remote is a project slug, not a remote). Fixes #2392. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…llow-up) The ported defaults table synthesized repo_mode → "unknown", but EMPTY is load-bearing for that key: gstack-repo-mode treats any non-empty answer as a user override and skips its own repo classification — the synthesized default turned the classifier into dead code (REPO_MODE=unknown everywhere; caught by test/gstack-repo-mode.test.ts via the wave's cross-agent blame protocol). repo_mode joins the empty-is-real carve-outs (empty output, exit 0). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The pair-agent headed switch spawned 'connect --force-restart'
unconditionally — auto-killing a live headless daemon (open tabs, cookies,
logins) in direct contradiction of the iron rule it sits beside ('only an
explicit --force-restart may kill a live daemon'). The CLI now captures
daemon liveness BEFORE ensureServer (which can itself boot a fresh daemon)
and relaunches only when the user passed --force-restart to pair-agent;
otherwise it prints the tab count and continues against the existing daemon.
The /pair-agent skill gains a matching one-way-door consent question
(template half rides the wave's template block).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ts user scope hasRemoteOnlyGbrainMcp scanned EVERY project's mcpServers in ~/.claude.json, so one project's remote gbrain registration reclassified broken local engines as thin-client machine-wide. It now reads user scope plus only the cwd's nearest-ancestor project key. The precedence itself was verified empirically and hermetically (fake HOME + CLAUDE_CONFIG_DIR fixtures, claude 2.1.233): with both scopes defining gbrain, 'claude mcp get gbrain' reports Scope: Local config — PROJECT-LOCAL WINS. Both in-repo consumers assumed the opposite; brain-cache's endpoint resolution flips to nearest-ancestor-project-first, and the stale user-first pin in brain-cache-roundtrip now pins the verified precedence. (The user-first jq in the brain-sync preamble resolver gets the same swap in the template block.) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…m (live misfile bug) Found live during this wave's CEO review: bin/gstack-slug emitted SLUG=garrytan for this garrytan/gstack worktree while remote-slug correctly gave garrytan-gstack — decisions, timeline, ceo-plans, and learnings were filing into the wrong project store (observed polluting Context Recovery with another repo's decisions). Root cause: a stray empty ~/.git directory made the walk-up crown $HOME as the outermost project root; the remote lookup ran only against that root, failed silently, and the basename fallback cached 'garrytan' sticky. NOT worktree-specific — any strong marker on a non-repo ancestor triggered it. Fix: the walk now finds the outermost ancestor whose .git actually resolves an origin remote and derives owner-repo with remote-slug's byte-identical parse; marker-only ancestors keep anchoring the basename fallback but can no longer shadow a real remote. A new cache self-heal recomputes the poisoned shape (cached == basename of a marker root while a remote-bearing repo exists below), preserving legit #2212 stickiness. Nested-repo walk-up, no-remote and non-git fallbacks, and the SLUG=/BRANCH= eval contract are unchanged, pinned by a 10-case parity suite. Store migration for pre-fix data is tracked in TODOS.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tructurally Producers appended lines to .brain-queue.jsonl while the drain re-read and os.replace'd it; the in-code comment admitted a lockless append between the re-read and the replace was lost. Locks and rename-rotation designs were both reviewed and rejected (each retained a tail race); the shipped design is a maildir-style spool: one FILE per record in .brain-queue.d/ (tmp + atomic rename), the drain snapshots filenames, processes, and deletes exactly what it snapshotted. Writer and drainer never share an inode — nothing to race. Semantics: at-least-once (a crash between process and unlink re-drains; downstream content-hash dedup absorbs duplicates); retained (privacy-held) records keep their files; unparseable records are kept + warned, never destroyed. Legacy .brain-queue.jsonl migrates atomically on the next drain (crash-leftover .migrating files recovered too); status/drop-queue count both surfaces; discover-new writes spool records and advances its cursor per-record-written. The preamble's queue-depth line switches to spool count in this wave's template block. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
slugFromEnvironment derived the slug from the INNERMOST repo's origin while bash gstack-slug walks to the outermost project root — nested/vendored repos split their stores across the bash/native boundary (win32 hits the native path constantly). The native fallback now ports _outermost_project_root faithfully (strong/weak markers, outermost-strong-wins, 64-depth cap, fixed-point termination) plus the full resolution order: env override → walk-up → sticky cache with the #1125 self-heal → remote get-url → basename. Twelve mirrored scenarios drive BOTH implementations against the same fixtures and pin identical slugs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…s, and keeps 3-digit width The degraded path counted every remote-tracking ref on every remote — stale experiment branches and second remotes inflated version allocation, and a failed base read flipped 3-digit repos to 4-digit slots. Now: ls-remote --heads origin first (GIT_TERMINAL_PROMPT=0, 5s timeout, zero local ref mutation); on failure, local refs/remotes/origin ONLY with an explicit stale-refs warning; a failed base read zeroes at the LOCAL version file's width so a 3-digit repo allocates 0.0.1, not 0.0.1.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… ones Registering hooks from a dev worktree baked that worktree's absolute path into settings.json — deleting the worktree left a dead hook erroring on every session stop, and the presence-only dedup (list-sources | grep) could never re-point it. setup's hook paths now route through _hook_install_path (global install preferred, source dir fallback), and the new ensure-event verb on gstack-settings-hook compares the registered command payload against canonical: identical → no write, different → single atomic replacement (never zero or two registrations). The plan-tune hooks had the same stale pattern and get the same fix without re-triggering their consent prompt. Also hardened: bun 1.3.13 turns an uncaught sync fs error in bun -e into a SILENT exit 0 — the registrar's write path now catches, prints, and exits 1, so a failed update can never report fake-green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
43 of 44 learnings entries came from explicit /learn — the completion-status prose read 'if you discovered a durable project quirk... log it', which models treated as optional. The step now ALWAYS runs: review the session for durable learnings, log each one, and state 'No durable learnings this session' explicitly when the review comes up empty — an empty result, never a skipped step. Re-derived from PR #2612 under the generated-file screening rule. Fixes #2402. Contributed by @Lockyer228 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…2441) /scrape and /skillify consumed page content with zero injection guidance — the CHANGELOG claimed coverage the skills didn't have. The warning now lives in ONE exported const (UNTRUSTED_CONTENT_WARNING in resolvers/browse.ts), embedded in the browse COMMAND_REFERENCE as before AND injected standalone into both skills via the new {{UNTRUSTED_CONTENT_WARNING}} token — single source, wording can never drift between surfaces. Re-derived from PR #2612 under the generated-file screening rule. (Structural isolation for skillify-generated code is tracked as its own TODO.) Fixes #2441. Contributed by @Lockyer228 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…2518) /review Step 2 read .claude/skills/review/checklist.md — a path relative to the TARGET repo, which only resolves in gstack's own checkout. Every checklist/greptile-triage/TODOS-format reference (six across five templates — two more than the issue named, same class) now uses the installed-root form ~/.claude/skills/gstack/review/... that the templates' other references already use. The install-root class itself (non-default install dirs) is #1882, deliberately its own PR. Fixes #2518. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ch (template half) The skill flow now checks daemon liveness before Step 4 and asks an explicit one-way-door question (tabs/cookies/logins are lost) before passing --force-restart — never proceeding on a vague reply. Pairs with the CLI-half commit that stopped pair-agent auto-killing live daemons. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Measured (#2387): every codex exec call pays Codex's session prelude, and a resumed call came in slightly ABOVE a fresh one — resume buys continuity, never token savings. The skill now says so where the resume flow lives: prefer one codex call per skill, batch questions into it. Fixes #2387. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…afe gate (#2517) /gstack-upgrade went straight to stash + reset --hard origin/main. Now it tries git pull --ff-only --autostash first (the same policy session-update's auto-upgrade uses). The destructive fallback runs unprompted ONLY when both git status --porcelain AND git rev-list origin/main..HEAD are empty — a clean tree with unpushed local commits is NOT safe, reset destroys them. Anything else requires an explicit one-way-door confirmation that lists every dirty file and unpushed commit being discarded. Fixes #2517. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…CP project-first Two resolver halves deferred from earlier wave commits: the queue-depth line counts .brain-queue.d/*.json spool records (plus legacy lines until the drain migrates them), and GBRAIN_MCP_ENTRY_JQ swaps its operands to nearest-ancestor-project-first — matching the empirically verified Claude Code precedence (project-local beats user scope) instead of the backwards user-first assumption. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…he template block) Pure generator output for the six template/resolver commits above (learnings capture, untrusted-content warning, review paths, pair-agent consent, codex resume note, upgrade ff-only, brain-sync block) — bun run gen:skill-docs + --host codex + --host factory, with the three ship golden fixtures refreshed per the documented procedure. The three sidecar-path pins in gen-skill-docs.test.ts move to the new installed-root/$GSTACK_ROOT contract (#2518). Restores template freshness; full suite green from here. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…-ups The v1.67 adversarial-review residuals section shrinks to the one item the wave couldn't reach (iOS tap routing — needs real-device verification). New entries: skillify structural isolation (a prose warning is not a boundary for page-derived generated code) and the slug store migration (pre-fix sessions on stray-marker machines filed data under the degraded slug; post-fix reads go to the correct store, so history needs a merge/alias). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Three suites pinned pre-wave behavior: browse's gstack-config test asserted the old unknown-key ''/exit-0 shape (#2611 made it exit 1); the Windows-paths suite pinned O_APPEND enqueue atomicity (the spool design satisfies the same invariant via tmp + os.replace, one file per record — pinned in its new form); and nine carve-guard skeleton ceilings absorbed the #2402 unconditional-learnings prose (~450B per skill), bumped with measured values per the guard's own protocol. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rooted review refs The self-check pinned the review checklist as a class-1 alias-relative ref; #2518 moved those refs to the installed gstack root (class 2). The guard now proves the scanner sees them in their new class, so the class-2 assertion can't go vacuous. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…osure) The coverage audit found one regression-shaped gap: nothing pinned that the upgrade template's ff-only pull precedes the gated reset --hard (#2517) — a future template edit reverting to reset-first would fail nothing. Pinned: the ordering, the FF_OK gate, and the unpushed-commits check. Also pinned the two minor gaps: the {{UNTRUSTED_CONTENT_WARNING}} injection points in scrape/skillify (#2441) and brain-uninstall's spool-dir cleanup. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rdened
The ship review army (4 specialists + red-team + checklist, 29 findings)
produced 8 mechanical auto-fixes and 11 decisions; the accepted set:
- win32 slug parity completed: lib/bin-context.ts gains the remote-first
outermost walk + degraded-cache self-heal the bash side got this wave —
the two implementations now agree on the stray-marker live-bug shape,
pinned by shared fixtures (multi-specialist 9/10 finding).
- probe honors the plan's bounded-read decision: 256KB prefix, extraction
semantics mirrored from parseTranscriptJsonl so probe/prepare can never
diverge on the same file (>1MB transcript test).
- policy normalize parity: bash normalize() now matches canonicalizeRemote
on .git/-trailing and uppercase-.GIT shapes (7-shape corpus pinned two
ways) — a deny for those shapes could previously slip the transcript gate.
- session-update reclaim is TOCTOU-safe (atomic mv-aside on both branches).
- settings-hook: unparseable settings.json errors instead of being replaced
with {}; ensure-event keys on (event, source) so matcher changes update
in place — never zero or two registrations.
- dot-only slug guard at both parse sites (hostile 'url = ..' can't escape
projects/); enqueue tmp-file janitor (1h TTL, inside the drain lock);
brain-sync .migrating never clobbered; drop-queue/status count .migrating;
snapshot -o warning correct + surfaced in diff mode; version-bump test
order-dependence removed; uninstall clears the advance stamp.
Deferred with record: slug heal-probe cost sentinel (P3 TODO), FF_OK
conflation (noted, misdiagnosis-only).
270 pass / 0 fail across the 10 touched suites.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ndings Three adversarial passes (Claude fresh-context, Codex chaos, Codex structured with P1 gate) on the full wave diff. Multi-source findings, all fixed: - P0: finalize_queue is now explicit-delete-only — a record is unlinked ONLY when classification proves it staged or dropped; a classifier crash, a missing class file, or a malformed pulled .brain-privacy-map.json (which previously nuked the whole snapshotted queue, remotely triggerable) now retains everything, warns, and re-drains next run. load_privacy_map treats corrupt maps as retain-all, never as empty. - next-version cannot silently drop a live claim: unreadable advertised refs get a targeted --depth=1 fetch + retry; still-unreadable claims surface as UNKNOWN warnings instead of duplicate-version silence. - session-update lock: ownership-checked EXIT trap (a TTL-reclaimed holder can no longer delete the new holder's lock) + a 5-min background heartbeat so a legitimately-slow pull/setup is never reclaimed while alive. - ensure-event collapses ALL same-(event,source) duplicates to one canonical entry; unique per-process tmp path; setup call sites surface (not swallow) the hardened refusals. - memory-ingest: --limit counts only policy-permitted pages (denied records no longer starve permitted ones); --probe applies the same policy filter as --bulk (skipped_policy_* fields on the report). - version-bump repair accepts a genuine literal 0.0.0.0 VERSION file. - slug heal restricted to the stray-.git shape — package.json-anchored wrapper roots keep their legit sticky identity (#2212 preserved). - brain-sync: idle fast path sees leftover .migrating records; unparseable spool records quarantine instead of warning forever; migration comment stops overclaiming the transition-window race. - CDP throttling justifications document override persistence (callers own restoration), pinned in the allowlist test. Deferred with record: deny retroactivity for already-ingested pages (P2 TODO, same semantics as the code-import gate); legacy-migration tail race (transition-window, requires pre-spool writers). 288 pass / 0 fail across the 10 touched suites. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Pure generator output for the brain-sync block's jq ancestor match now accepting backslash-formed Windows project keys — previously project-scoped brains were invisible on Windows while the TS scope resolvers saw them. Golden ship fixtures refreshed per the documented procedure. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ial count, migrating depth The verify re-review passed the P1 gate (0 P1s) and left three residuals, all applied: transcriptCwdFromPrefix reads in chunks until one complete record (4MB cap) so a giant first prompt can't truncate mid-JSON and break probe/bulk parity; partial_pages derives from the FINAL prepared set instead of the whole scanned corpus; the preamble queue-depth line counts leftover .brain-queue.jsonl.migrating records like the status path does (regen + goldens included). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
BROWSER.md: fix the $B cdp example (positional JSON params, not --json; depth is the real CDP param) and add the new perf-throttling examples (Emulation.setCPUThrottlingRate, Network.emulateNetworkConditions) with their clear-override counterparts. USING_GBRAIN_WITH_GSTACK.md: the state-files table row for the sync queue now names the maildir-style spool dir .brain-queue.d/ that replaced .brain-queue.jsonl this release. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tract The paid-tier E2E pinned the pre-fix contract (probe headline = raw discovered). Probe now counts post-attribution — the same gate --bulk uses — with an explicit unattributed-skip line. Adds the --include-unattributed companion pin so all 9 fixtures stay accounted for. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
😎 This pull request was merged. |
E2E Evals: ❌ FAIL62/63 tests passed | $8.73 total cost
ubicloud-standard-8 runners (Docker: pre-baked toolchain + deps) | wall clock ≈ slowest suite Failures
|
…, never a per-branch crawl The targeted-fetch retry for branches whose advertised tip has no local object ran ONE git fetch per branch (10s cap each). On a shallow clone against a busy remote that crawls the network for minutes — CI's shard deadline killed the free suite mid-file. Missing tips now collect into a single batched shallow fetch (15s cap); refs still missing after the batch (one unservable ref fails the whole transfer) get a capped per-branch retry, and anything past the cap warns as an UNKNOWN claim instead of fetching. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… tests hermetic Two new G2 pins: N unfetched claim branches resolve with exactly ONE fetch spawn (PATH-shimmed git counts invocations), and one unservable ref no longer poisons the batch — live claims resolve via the bounded retry while only the ghost warns UNKNOWN. The #2545 offline-contract tests now run the CLI in a local fixture repo instead of the repo's own checkout: the checkout path did a live ls-remote against the real origin (operator-network-dependent, and the CI shard-deadline hang). The online-contract test gains a succeeding gh stub, so fallback:null is asserted deterministically instead of only when the operator happens to be authed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…s credential literal in source The CI quality gate scans every ADDED diff line with the redact engine, so the #2610 port's raw fixture literals failed the very gate they exist to test. The fixture is now assembled at runtime; the scanner still receives the identical bytes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
CHANGELOG keeps both entries in release order (1.68.0.0 above 1.67.2.0); VERSION and package.json keep the branch's higher claim. Generated SKILL.md files verified byte-exact against a fresh regen from the merged templates. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ls the last environment dependence The hermetic offline-contract fixture had no origin remote, so detectHost() fell through to auth probes: a machine with glab authed passed via the gitlab path while a bare CI runner read host:unknown (offline stays false there) and failed. The fixture now pushes to a local bare origin at a path containing github.com — the URL sniff pins host:github identically everywhere, asserted explicitly in both tests, with every git call still local. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The next tracker wave after v1.67: 16 verified fixes in, 90 stale PRs and 21 issues closed out with receipts. 41 commits, 139 files, +6,669/−672 (vs the merged v1.67.2.0 base). Six community contributors credited; every ported fix was re-derived against the live tree (generated SKILL.md never taken from fork PRs) and regression-pinned in the free suite.
Community PR ports (credited in CHANGELOG)
8fe5f5a2plan-tune rejects never-ask on one-way ids at--write, and--statsreports inert pre-fix prefs (gstack-question-preference --write accepts never-ask on one-way ids: preference stores, --stats reports it configured, --check refuses it forever #2488) — @szsunyuan1164c038+565ca9b1gstack-config geton unknown keys exits 1, single-table defaults (no drift possible),repo_modecarve-out preserved (Fix: gstack-config get returns "" with exit 0 for keys that have no default #2611) — @benjaminberes-bpca671d6ftypo'dgstack-redactsubcommand no longer exits 0 having scanned nothing (fix(redact): a typo'd subcommand no longer exits 0 having done nothing #2610) — @kinoko-studio9c4de4feone ambiguous ref no longer kills the whole annotated screenshot; exact-first, counted first-match fallback, visible skip summary — @namtrokf9f0e84amissing/empty VERSION no longer repairs a fabricated 0.0.0.0 into package.json (gstack-version-bump repairwrites a fabricated0.0.0.0into package.json when it cannot find VERSION — and the package.json path cannot be configured to avoid it #2600) — @Lockyer2280762fab8memory-ingest --probecounts post-attribution through the same shared gate--bulkuses (--probe reports pre-filter counts, and setup-gbrain gates a silent bulk ingest on them #2394) — @Lockyer22863ef693dCPU + network throttling CDP allowlist entries for performance measurement — @henbimaCore + medium fixes
ddeeb18esession-update lock pidfile records the live subshell (BASHPID), hard TTL + heartbeat bounds every wedge, PID-reuse safe (session-update: lock records the parent $$ from a backgrounded subshell, so the stale-lock branch lets every concurrent session in #2613)c4d91507explicitwindowsHideon every Bun.spawn site + census tripwire (Windows: terminal-agent spawns a visible console window that steals keyboard focus #2575 residual)24942767memory-ingest honors per-remote deny/read-only trust policy: one batch spawn, three outcome classes, abort-pre-write on unreadable store (memory-ingest does not honour the deny trust policy that memory.md promises #2392)40e4a53fbrain worktree advances on the daily sync — no more silently stale brains; refuses dirty trees, never force-removes on the unattended path (gbrain source worktree never advances after setup: artifacts push fine but brain silently stays at 0 pages #2516)Residuals (TODOS.md adversarial items)
6df30370brain-sync queue is now a per-record spool dir (maildir pattern) — the enqueue/drain race dies structurally; at-least-once with content-hash dedup6955dfa3+423a963dpair-agent asks consent before killing a healthy headless daemon (CLI half + one-way-door template half)e57b2798gstack-slugmatchesremote-slug's owner-repo canonical form — fixes a live misfile bug where decisions/timeline filed into the wrong project store (existing store migrated)d8a207fdgbrain-status MCP scoping is per-project; project-local beats user scope (verified empirically against a pinned CLI, hermetic fixtures)7f749f94win32bin-contextslug fallback walks up like bashgstack-slugbdc0b116next-version git fallback queries the live remote via non-mutatingls-remote, keeps 3-digit width on failed base readsc9b5ccddsetup hooks register the global-install path and re-point stale ones (update-in-place, never zero or two registrations)Template block (contiguous, closed by single regen — repo bisection convention)
ddc413edlearnings capture is unconditional at completion (Learnings auto-capture is advisory only: 43 of 44 entries came from explicit /learn, none from /review, /ship or /investigate #2402) — @Lockyer228a1cf3f2buntrusted-content warning on the page-fetching skills (Untrusted-content warning missing from page-fetching skills; CHANGELOG overclaims coverage #2441) — @Lockyer228879beb98review checklist/greptile paths resolve from the installed skill root (fix(review): resolve checklist paths from installed skill root #2518)c8564720codex resume docs: resume does not amortize the ~21K session prelude (Measured: every codex exec call pays ~21K tokens of session overhead, and resume does not avoid it #2387)6ad9db51upgrade fast-forwards first;reset --hardonly behind a proved-safe gate (clean tree AND no unpushed commits) or explicit consent (fix(upgrade): preserve local changes instead of reset hard #2517)fc21193ebrain-sync block counts the spool queue, resolves MCP project-first0066bec8single regen + refreshed golden fixturesHardening rounds (pre-landing review + adversarial + codex verify)
b7d44c45review round: 8 auto-fixes + 8 accepted findings hardenedfd0dbdeeadversarial round: P0 finalize fail-safe in brain-sync (corrupt privacy map = retain-all, classifier exit checked, explicit-delete-only) + 12 hardened findingsef3bb1f6Windows-separator jq fix + regen518599cbcodex verify-pass residuals: chunked cwd read (256KB chunks, 4MB cap), post-filter partial count, migrating depth9fecf0f1+a54802dc+25a7e31eprose-tier behavior pins (coverage-audit gap closure) + cross-cutting test alignmentf479f900memory-pipeline paid-tier pins aligned to the --probe reports pre-filter counts, and setup-gbrain gates a silent bulk ingest on them #2394 stage-count contract (caught by the gate-tier eval run)2cdd727e+5dac88b2next-version's missing-tip fetch is now ONE batched round trip with a capped per-ref retry — the per-branch fetch loop ground CI's shallow clone against the live branch census for minutes (caught by the free-tests CI shard deadline); the v1.63.1.0 fix(ship): allocate from git when the PR queue is unreachable #2545 offline-contract tests now run hermetically in fixture repos with a stubbedgh, and the batch is pinned by a PATH-shimmed fetch-spawn countc4907640the redact-cli test's synthetic AWS-key fixture is derived at runtime, so the CI quality gate (which scans added diff lines with the same engine) no longer trips on the scanner's own test inputsa57095e4merge of v1.67.2.0 from main mid-flight: CHANGELOG keeps both entries in release order, generated SKILL.md files verified byte-exact against a fresh regen from the merged templates8c9e81d2TODOS.md: six wave-fixed residuals struck, two follow-ups added (skillify structural isolation; Skills hardcode~/.claude/skills/gstack/paths — any install dir not namedgstacksilently breaks aftersetup#1882 install-root class)Behavior change worth knowing (#2611):
gstack-config get <unknown-key>now exits 1 instead of 0-with-empty. Downstream scripts underset -ewithout a|| fallbackon unknown keys will now stop instead of silently proceeding. Carve-outs (empty + exit 0) preserved:cross_project_learnings,salience_allowlist,user_slug_at_*,redact_repo_visibility,repo_mode.Test Coverage
Coverage audit: 96% of the wave's behavior changes carry a free-tier regression pin; the one audited gap (prose-tier ship behaviors) was closed by
9fecf0f1before landing.Tests: 7,731 → 7,878 (+147 net new cases, 159 added / 12 moved, across 32 touched test files). Full suite green on the final tree: 7 shards, 471 files, 0 fail (~4.5 min under load).
Pre-Landing Review
Three rounds, all absorbed pre-merge:
b7d44c45, rest verified false-positive/by-design with receipts.codex execadversarial +codex review --base): 8+18+11 findings → P0 brain-sync finalize fail-safe + 12 hardened infd0dbdee, residuals in518599cb.Design Review
No frontend files changed — design review skipped.
Eval Results
Gate tier (the CI merge-blocking set) — green. Sharded run via
eval:bg:gate(one Bun process per test file, per-shard timeouts): 40/45 shards executed — 38 passed, 0 timed out, 0 never started, 5 skipped by diff; 86 test verdicts recorded in the per-file dashboards, all passing; total cost $13.70. The 2 shard-level failures both resolved with receipts:skill-e2e-memory-pipeline— a stale paid-tier pin of the pre---probe reports pre-filter counts, and setup-gbrain gates a silent bulk ingest on them #2394 probe contract (headline = raw discovered count). Aligned to the stage-count contract inf479f900(post-attribution headline + explicit unattributed-skip line, plus an--include-unattributedcompanion pin so all 9 fixtures stay accounted for). File now 11/11.skill-e2e-plan-devex-plan-mode— timeout artifact under 4-way shard concurrency: the PTY judge observed the agent actively working at the 300s window on both attempts, never a wrong outcome. Standalone re-run on a quiet box: 2/2 pass (440s).Supplementary tierless sweeps on the same final skill content: 103 distinct test verdicts — 102 PASS, 1 FAIL. The one FAIL is
/design-consultation core: pre-existing (FAIL → FAIL against the prior main-side baseline; periodic tier, not merge-blocking). The LLM-judge suite scored 25/26 with the single miss retry-passing in-run (judge variance at the score threshold, 3→4 on identical content — effective 26/26).Per-file cost/turn dashboards with auto-comparison against the previous finalized run are saved under
~/.gstack/projects/garrytan-gstack/evals/(shard dirs included).Plan Completion
Plan:
gstack fix wave — next wave after v1.67.1.0(CEO + ENG CLEARED, 2 codex rounds absorbed — 26/34 outside-voice findings folded into the design pre-implementation).31/34 items DONE, 0 NOT DONE, 3 intentionally routed out per the plan's own escape hatches (documented in TODOS.md / close-out comments). Close-out checklist executed during the wave: 90 absorbed/stale PRs closed with CHANGELOG-credit receipts, 21 issues closed with version pointers, 0 close failures.
Security note: PR #2579 (PHP SEO-doorway script planted as
agents/tredfg.html) was closed without comment; the GitHub abuse report (account: Sevak-ire) is handed to the repo owner — the web form at https://github.com/contact/report-abuse requires a human account holder.Post-merge follow-ups (tracked): close ported PRs #2607 #2611 #2610 #2601 #2612 #2602 with porting receipts; wave-fixed issues auto-close via Fixes-lines (#2488 #2600 #2394 #2402 #2441 #2613 #2518 #2387 #2517 #2392 #2516); deploy to the active skill per CLAUDE.md.
Documentation
Doc diff preview:
BROWSER.md: fixed the$B cdpexample (the CLI takes positional JSON params, not--json;depthis the real CDP param name) and added how-to examples for the newly allowlisted perf-throttling methodsEmulation.setCPUThrottlingRate/Network.emulateNetworkConditions, including the clear-override calls since both persist on the tab until cleared.USING_GBRAIN_WITH_GSTACK.md: state-files table now documents the maildir-style spool dir~/.gstack/.brain-queue.d/(one file per record) that replaced~/.gstack/.brain-queue.jsonlthis release; legacy queues migrate on the next drain.docs/gbrain-sync.md(daily sync now advances the brain worktree, gbrain source worktree never advances after setup: artifacts push fine but brain silently stays at 0 pages #2516),setup-gbrain/memory.md(transcript ingest honors the per-remote deny/read-only trust policy, memory-ingest does not honour the deny trust policy that memory.md promises #2392),TODOS.md(6 wave-fixed residuals struck, follow-ups filed),CHANGELOG.md+VERSION(v1.68.0.0).Documentation Debt
gstack-gbrain-repo-policy get --batch— new flag has reference coverage in CHANGELOG only; missing from the bin-helper table in USING_GBRAIN_WITH_GSTACK.md (reference + how-to gap).gstack-config get <unknown-key>exit-1 behavior change — documented as a CHANGELOG behavior-change callout, but no standing reference doc covers gstack-config exit codes (reference gap, minor)./document-generatecan fill both gaps post-merge.Cross-model doc review: attempted (default-on) but unavailable this run — Codex failed on an unrelated MCP auth error and the Claude fallback hit API 529s; the manual doc audit covered the same checks.
🤖 Generated with Claude Code