v1.62.0.1 fix: recognize Claude Keychain authentication - #2548
Closed
shawnacalia wants to merge 2 commits into
Closed
v1.62.0.1 fix: recognize Claude Keychain authentication#2548shawnacalia wants to merge 2 commits into
shawnacalia wants to merge 2 commits into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
9 tasks
Owner
|
Closing: this was absorbed or superseded on main by v1.67.0.0 or earlier (see the v1.67 tracker-wave receipts in PR #2604). Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude auth status --textbefore applying legacy authentication heuristics, so macOS Keychain-backed Claude Code sessions are recognized.ANTHROPIC_API_KEYfallbacks for older CLI versions and API-key-based setups.1.62.0.1with a changelog entry.Test Coverage
All new behavior is covered by generated-skill assertions. The new CLI probe is pinned in the Codex output and every external-host rendering; the explanatory Keychain guidance is also pinned in the Codex output.
Pre-Landing Review
No issues found. The auth probe is silent, delegates secure-store detection to Claude Code itself, and falls back safely when older clients do not support
auth status.Design Review
No frontend files changed — design review skipped.
Eval Results
bun test: passed the full free suite.bun test test/gen-skill-docs.test.ts: 405 passed, 0 failed.bun run gen:skill-docs --host codex --dry-run: all generated Codex skills fresh.bun run test:evals: 48 passed, 341 skipped, 12 failed. The failures were environment-limited and unrelated to this diff: Claude-backed routing runs returned no model output/tool calls, and an always-on Swift fixture could not importXCTest.bun run build: generated all host skills and compiled binaries, then stopped in the packaging phase because the local shell advertises an unavailableC.UTF-8locale to Perl. No tracked build artifacts changed.Scope Drift
Scope Check: CLEAN. The implementation is confined to the Claude skill template, its generator regressions, and required release metadata.
Plan Completion
No plan file detected.
TODOS
No TODO items completed in this PR.
Documentation
Updated
CHANGELOG.mdfor1.62.0.1. No additional user documentation changes are needed because the behavior and compatibility fallbacks are documented directly in the generated skill instructions.Test plan
gstack-redactwith zero findingsGenerated with OpenAI Codex.