fix(config): make key validation locale-independent - #2506
Open
Math1987 wants to merge 1 commit into
Open
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2494
Why
POSIX bracket ranges follow locale collation. With GNU grep under tr_TR.UTF-8, the ASCII letter i can fall outside [a-z], so valid config keys are rejected and skill preambles silently fall back to their defaults.
Tests
bun test test/gstack-config-key-locale.test.ts test/user-slug-fallback.test.ts test/docs-config-keys.test.ts test/explain-level-config.test.ts test/gstack-config-redact-keys.test.ts— 35 pass, 0 failbash -n bin/gstack-configgit diff --checkFull-suite note
I also attempted
bun test, but it did not complete cleanly in my multi-repository macOS workspace: unrelated existing suites timed out or depended on unavailable local services and fixture assumptions (including global discovery, gbrain fixtures, and local server binding). The focused config suite above is green.