fix(setup): accept --host cursor and --host slate (#2361) - #2432
Closed
gregario wants to merge 1 commit into
Closed
Conversation
Fixes garrytan#2361. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
9 tasks
Owner
|
Closing: this was absorbed or superseded on main by v1.67.0.0 or earlier (see the v1.67 tracker-wave receipts in PR #2604). Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2361 —
./setup --host cursorand./setup --host slateexit with "Unknown --host value" even though both hosts have full configs inhosts/cursor.tsandhosts/slate.tsand are registered inALL_HOST_CONFIGS.The case statement at setup line 104 listed only
claude|codex|kiro|factory|opencode|autoas pass-through hosts. Cursor and Slate are local IDE hosts with the same installation pattern (directory-based skill discovery) but were never added to the allowlist. The fix adds them alongside the other local hosts.Verification
bun test test/setup-host-validation.test.tsgreen (3/3)setupcauses both failuresCo-Authored-By: Claude Opus 4.6 noreply@anthropic.com