Skip to content

Some more CDATA fixes - #90

Merged
cdwensley merged 1 commit into
masterfrom
mh/cdata
Jul 30, 2026
Merged

Some more CDATA fixes#90
cdwensley merged 1 commit into
masterfrom
mh/cdata

Conversation

@fingolfin

Copy link
Copy Markdown
Member

Not sure why I missed these before.

@cdwensley

Copy link
Copy Markdown
Collaborator

Hope this is not taking up a lot of your time.
Have merged the PRs in the other packages, but XModAlg must wait until I have finished some other development.

@fingolfin

Copy link
Copy Markdown
Member Author

No problem -- I have a python script that I can run on the code.

So basically, do your work; if you think it is a good time, just ping me, and it'll take me 2-3 minutes to update this PR

@codecov

codecov Bot commented Mar 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.09%. Comparing base (64a8ae6) to head (266598d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   72.09%   72.09%           
=======================================
  Files          10       10           
  Lines        2584     2584           
=======================================
  Hits         1863     1863           
  Misses        721      721           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Not sure why I missed these before.
@fingolfin

Copy link
Copy Markdown
Member Author

@cdwensley just wondering if this can be merged now or should still wait for some other work?

If the other work is PR #91, I think there are no overlaps between the two?

@cdwensley
cdwensley merged commit 927c05a into master Jul 30, 2026
5 checks passed
@cdwensley
cdwensley deleted the mh/cdata branch July 30, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants