Use local server for download tests - #99
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 85.21% 85.56% +0.34%
==========================================
Files 32 32
Lines 1867 1905 +38
==========================================
+ Hits 1591 1630 +39
+ Misses 276 275 -1
🚀 New features to boost your workflow:
|
|
This should be much more reliable |
Replace live network assertions with a forked HTTP server provided by the IO test dependency. Teach the SingleHTTPRequest adapter to handle explicit ports so every backend can use the ephemeral local address. Keep the public HTTPS transcript as non-executable documentation. Co-authored-by: Codex <codex@openai.com>
095e711 to
4ef18fb
Compare
Exercise URLs without paths, authority-only fragments, and malformed authorities in the SingleHTTPRequest adapter tests. Co-authored-by: Codex <codex@openai.com>
|
Assuming the tests are (again) green this can should be merged. Then afterwards I can update PR #98 |
|
@cdwensley could you please make a new utils release with this in? The utils test suite has many many fluke failures in the package distro which requires manual intervention each time |
|
@fingolfin done. Now that Utils CI is working correctly, should I be making similar changes to the other packages? |
Thanks!
Aren't they all already updated in terms of the |
2 participants
Replace live network assertions with a forked HTTP server provided by
the IO test dependency. Teach the SingleHTTPRequest adapter to handle
explicit ports so every backend can use the ephemeral local address.
Keep the public HTTPS transcript as non-executable documentation.
Co-authored-by: Codex codex@openai.com
Closes #97