Let NumberSmallGroups take the selection criteria of AllSmallGroups - #72
Merged
Merged
Conversation
NumberSmallGroups(96, IsAbelian) is 7, and a list of orders is accepted as well. Counting means listing the ids, so it costs what IdsOfAllSmallGroups costs; per-layer counting methods can follow. Fixes #68 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 507 507
Lines 370982 371002 +20
=======================================
+ Hits 370557 370577 +20
Misses 425 425
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumberSmallGroups(96, IsAbelian)is 7, and a list of orders is accepted aswell:
A thin wrapper for now: with criteria it counts what
IdsOfAllSmallGroupsreturns, so it costs what that costs -- the indexed criteria narrow the range
first and only the groups a remaining criterion must be tested on get built.
Orders alone are answered from the numbers of groups, constructing nothing.
Being a wrapper, it needs nothing from the layers, so sglppow and SOTGrps gain
the feature untouched. Per-layer counting methods can follow, and so can a
place for this in whatever #67 turns the layering into.
Fixes #68
🤖 Generated with Claude Code