Skip to content

Let NumberSmallGroups take the selection criteria of AllSmallGroups - #72

Merged
fingolfin merged 1 commit into
masterfrom
claude/numbersmallgroups-filters-c61380
Aug 7, 2026
Merged

Let NumberSmallGroups take the selection criteria of AllSmallGroups#72
fingolfin merged 1 commit into
masterfrom
claude/numbersmallgroups-filters-c61380

Conversation

@fingolfin

Copy link
Copy Markdown
Member

NumberSmallGroups(96, IsAbelian) is 7, and a list of orders is accepted as
well:

gap> NumberSmallGroups( [ 1 .. 100 ] );
1048
gap> NumberSmallGroups( 96, IsAbelian );
7

A thin wrapper for now: with criteria it counts what IdsOfAllSmallGroups
returns, so it costs what that costs -- the indexed criteria narrow the range
first and only the groups a remaining criterion must be tested on get built.
Orders alone are answered from the numbers of groups, constructing nothing.

Being a wrapper, it needs nothing from the layers, so sglppow and SOTGrps gain
the feature untouched. Per-layer counting methods can follow, and so can a
place for this in whatever #67 turns the layering into.

Fixes #68

🤖 Generated with Claude Code

NumberSmallGroups(96, IsAbelian) is 7, and a list of orders is accepted
as well. Counting means listing the ids, so it costs what
IdsOfAllSmallGroups costs; per-layer counting methods can follow.

Fixes #68

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.88%. Comparing base (ce4a0e6) to head (7bb9cd5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         507      507           
  Lines      370982   371002   +20     
=======================================
+ Hits       370557   370577   +20     
  Misses        425      425           
Files with missing lines Coverage Δ
gap/small.gd 100.00% <ø> (ø)
gap/small.gi 97.65% <100.00%> (+0.08%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin
fingolfin merged commit b4f1f98 into master Aug 7, 2026
5 checks passed
@fingolfin
fingolfin deleted the claude/numbersmallgroups-filters-c61380 branch August 7, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: add CountSmallGroups (or so) which just returns the number of groups with certain properties, not their ids or the groups themselves

1 participant