Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 71.61% 71.74% +0.12%
==========================================
Files 88 88
Lines 13076 13096 +20
==========================================
+ Hits 9365 9396 +31
+ Misses 3711 3700 -11
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #249, closes #256. Supersedes #252 and #257 (and takes into account the feedback given on those PR's).
This allows specifying the generators in
IsMatrixRepresentationmanually. It defaults toGeneratorsOfGroupif not supplied, instead of the oldGeneratorsOfPcp, which was undocumented and problematic.Seems more useful to me this way, and it lets us use this more safely internally (e.g. in
AffineRepresentation).AI Disclosure: bugs discovered by GPT-6 Astra during a package audit.