Skip to content

Fix matrix representation functions - #288

Open
stertooy wants to merge 1 commit into
gap-packages:masterfrom
stertooy:fix-all-matrep-things
Open

stertooy wants to merge 1 commit into
gap-packages:masterfrom
stertooy:fix-all-matrep-things

Conversation

@stertooy

Copy link
Copy Markdown
Collaborator

Closes #249, closes #256. Supersedes #252 and #257 (and takes into account the feedback given on those PR's).

This allows specifying the generators in IsMatrixRepresentation manually. It defaults to GeneratorsOfGroup if not supplied, instead of the old GeneratorsOfPcp, which was undocumented and problematic.

Seems more useful to me this way, and it lets us use this more safely internally (e.g. in AffineRepresentation).

AI Disclosure: bugs discovered by GPT-6 Astra during a package audit.

@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.29412% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.74%. Comparing base (4798827) to head (d6b6c3b).

Files with missing lines Patch % Lines
gap/matrep/affine.gi 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   71.61%   71.74%   +0.12%     
==========================================
  Files          88       88              
  Lines       13076    13096      +20     
==========================================
+ Hits         9365     9396      +31     
+ Misses       3711     3700      -11     
Files with missing lines Coverage Δ
gap/matrep/matrep.gi 96.44% <100.00%> (+3.36%) ⬆️
gap/matrep/affine.gi 11.32% <0.00%> (-0.45%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant