Robustness of CI#2239
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aims to reduce CI flakiness caused by network issues by separating SonarQube from unit tests and introducing caching/fallback behavior for external resources (Sonar scanner binary, CORSIKA interaction tables, simulation models).
Changes:
- Split SonarQube analysis into a dedicated
sonarqubejob, using a cached Sonar scanner and retry logic, and allowing soft-fail on draft PRs. - Upload/download a coverage artifact to feed SonarQube independently of the unit test job.
- Add cache restore/save + “clone-then-fallback-to-cache” logic for CORSIKA interaction tables and simulation models in integration tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/changes/2239.maintenance.md | Adds a changelog fragment describing CI robustness improvements. |
| .github/workflows/CI-unittests.yml | Separates SonarQube into its own job and passes coverage via artifacts; adds scanner caching/retry logic. |
| .github/workflows/CI-integrationtests.yml | Adds caching and fallback behavior for GitLab-hosted interaction tables and simulation models to mitigate network failures. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





A lot of CI runs are failing with network issues. This PR tries to increase the robustness.
CI Unit tests.
https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-8.1.0.6389-linux-x64.zip). Add a caching step for this binary.CI Integration Tests