Skip to content

Robustness of CI#2239

Merged
GernotMaier merged 19 commits into
mainfrom
ci-robustness
Jun 3, 2026
Merged

Robustness of CI#2239
GernotMaier merged 19 commits into
mainfrom
ci-robustness

Conversation

@GernotMaier
Copy link
Copy Markdown
Contributor

@GernotMaier GernotMaier commented Jun 3, 2026

A lot of CI runs are failing with network issues. This PR tries to increase the robustness.

CI Unit tests.

  • clearly separate Sonar from the unit tests. This does not increase robustness, but allows to see easier that the issue is with sonar and not with the unit tests (e.g., in a draft PR, would ignore the message then).
  • some sonar runs fail already when downloading the sonar binary (https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-8.1.0.6389-linux-x64.zip). Add a caching step for this binary.
  • retry 3x sonar analysis for connection issues.
  • allow sonar to fail if the PR is in draft status.

CI Integration Tests

  • cache both simulation models and CORSIKA interaction tables
  • first try to run the git clone of both repositories (as before). If this fails, fall back to the cached version.

@GernotMaier GernotMaier self-assigned this Jun 3, 2026
@GernotMaier GernotMaier marked this pull request as ready for review June 3, 2026 11:37
@GernotMaier GernotMaier requested a review from Copilot June 3, 2026 11:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request aims to reduce CI flakiness caused by network issues by separating SonarQube from unit tests and introducing caching/fallback behavior for external resources (Sonar scanner binary, CORSIKA interaction tables, simulation models).

Changes:

  • Split SonarQube analysis into a dedicated sonarqube job, using a cached Sonar scanner and retry logic, and allowing soft-fail on draft PRs.
  • Upload/download a coverage artifact to feed SonarQube independently of the unit test job.
  • Add cache restore/save + “clone-then-fallback-to-cache” logic for CORSIKA interaction tables and simulation models in integration tests.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
docs/changes/2239.maintenance.md Adds a changelog fragment describing CI robustness improvements.
.github/workflows/CI-unittests.yml Separates SonarQube into its own job and passes coverage via artifacts; adds scanner caching/retry logic.
.github/workflows/CI-integrationtests.yml Adds caching and fallback behavior for GitLab-hosted interaction tables and simulation models to mitigate network failures.

Comment thread docs/changes/2239.maintenance.md Outdated
Comment thread .github/workflows/CI-integrationtests.yml
Comment thread .github/workflows/CI-integrationtests.yml
Comment thread .github/workflows/CI-integrationtests.yml Outdated
GernotMaier and others added 6 commits June 3, 2026 13:44
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ctao-sonarqube
Copy link
Copy Markdown

ctao-sonarqube Bot commented Jun 3, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@GernotMaier GernotMaier added the Skip review PR without required review label Jun 3, 2026
@GernotMaier GernotMaier merged commit 8ebbc14 into main Jun 3, 2026
21 checks passed
@GernotMaier GernotMaier deleted the ci-robustness branch June 3, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip review PR without required review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants