Refactored inputs for GrantAbility nodes#43
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the GrantAbility Statescript nodes’ inputs to use Entity terminology instead of Target, and removes the built-in “activate on grant” behavior from the state node in favor of composing with TryActivateAbilityNode.
Changes:
- Renamed the grant recipient input from
TargetInputtoEntityInput(and updated input labels/docs accordingly). - Removed
tryActivateOnGrantfromGrantAbilityNode, shifting activation to a separateTryActivateAbilityNodepath. - Updated Statescript node tests and documentation to reflect the new API and recommended usage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Forge/Statescript/Nodes/State/GrantAbilityNode.cs | Renames recipient input to EntityInput and removes tryActivateOnGrant activation-on-grant behavior. |
| Forge/Statescript/Nodes/Action/GrantAbilityPermanentlyNode.cs | Renames recipient input to EntityInput and updates parameter labels/usages. |
| Forge.Tests/Statescript/Nodes/GrantAbilityNodesTests.cs | Updates bindings and replaces “activate on grant” testing with composition via TryActivateAbilityNode. |
| docs/statescript/nodes/state/grant-ability-node.md | Removes constructor param docs and updates input label; adds guidance on activation via TryActivateAbilityNode. |
| docs/statescript/nodes/action/grant-ability-permanently-node.md | Updates parameter label/reference from Target → Entity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Removed