Skip to content

Refactored inputs for GrantAbility nodes#43

Merged
lextatic merged 2 commits into
mainfrom
feature/refactored-input-for-grant-ability-nodes
Jul 22, 2026
Merged

Refactored inputs for GrantAbility nodes#43
lextatic merged 2 commits into
mainfrom
feature/refactored-input-for-grant-ability-nodes

Conversation

@lextatic

Copy link
Copy Markdown
Contributor

Changed

  • Changed TargetInput name to EntityInput on grant ability nodes.

Removed

  • Removed tryActivateOnGrant from GrantAbility node.

@lextatic lextatic added the changed Changes in existing functionality label Jul 22, 2026
@lextatic
lextatic requested a review from Copilot July 22, 2026 02:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the GrantAbility Statescript nodes’ inputs to use Entity terminology instead of Target, and removes the built-in “activate on grant” behavior from the state node in favor of composing with TryActivateAbilityNode.

Changes:

  • Renamed the grant recipient input from TargetInput to EntityInput (and updated input labels/docs accordingly).
  • Removed tryActivateOnGrant from GrantAbilityNode, shifting activation to a separate TryActivateAbilityNode path.
  • Updated Statescript node tests and documentation to reflect the new API and recommended usage.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Forge/Statescript/Nodes/State/GrantAbilityNode.cs Renames recipient input to EntityInput and removes tryActivateOnGrant activation-on-grant behavior.
Forge/Statescript/Nodes/Action/GrantAbilityPermanentlyNode.cs Renames recipient input to EntityInput and updates parameter labels/usages.
Forge.Tests/Statescript/Nodes/GrantAbilityNodesTests.cs Updates bindings and replaces “activate on grant” testing with composition via TryActivateAbilityNode.
docs/statescript/nodes/state/grant-ability-node.md Removes constructor param docs and updates input label; adds guidance on activation via TryActivateAbilityNode.
docs/statescript/nodes/action/grant-ability-permanently-node.md Updates parameter label/reference from Target → Entity.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Forge/Statescript/Nodes/State/GrantAbilityNode.cs Outdated
Comment thread docs/statescript/nodes/state/grant-ability-node.md
@lextatic
lextatic merged commit 0b2e15d into main Jul 22, 2026
1 check passed
@lextatic
lextatic deleted the feature/refactored-input-for-grant-ability-nodes branch July 22, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changed Changes in existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants