docs: correct stale unityVersion input description - #327
Conversation
The description claimed a non-"auto" unityVersion for a full project is "currently ignored" with "no override flag yet" - that hasn't been true since the thin-wrapper rewrite (#310): test-args.ts maps it to an explicit --engineVersion=<value> CLI flag, which game-ci/cli's engine-detection middleware genuinely respects as an override rather than clobbering it (see its own "respects an explicit --engineVersion instead of overwriting it" test). Misleading as written - it tells every reader of the input docs that per-job version overrides don't work, which is exactly the pattern a matrix testing one project against several Unity versions relies on. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe ChangesUnity version documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The action input documentation now accurately describes the existing Unity version override behavior without changing runtime code or deployment behavior. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |

Summary
Found while investigating a community report (Discord) about a Unity 6000.6.x retry-cycle failure in a downstream user's workflow (MirrorNetworking/Mirror, which runs a matrix of
unityVersionoverrides against this action). While confirming their per-jobunityVersionoverride still works correctly under the thin-wrapper (#310), I noticed the input's own description contradicts the code.action.ymlcurrently says:That hasn't been true since #310.
src/test-args.tsmaps a non-"auto"unityVersionto an explicit--engineVersion=<value>CLI flag:and
game-ci/cli's engine-detection middleware genuinely respects that as an override rather than clobbering it with auto-detection - covered by its own test,'respects an explicit --engineVersion instead of overwriting it'.As written, the description tells every reader that per-job version overrides don't work at all - which is exactly the pattern a CI matrix testing one project against several Unity versions relies on (Mirror's own use case). This PR only corrects the description text to match actual behavior; no code changes.
Test plan
test-args.ts's mapping and the CLI's engine-detection override behavior were both already correct and already covered by existing testsyarn test- all 20 tests pass (unaffected, doc-only change)🤖 Generated with Claude Code
Summary by CodeRabbit