-
-
Notifications
You must be signed in to change notification settings - Fork 24
Thin wrapper: invoke game-ci/cli as a subprocess #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e4310d5
Make action a thin wrapper around game-ci/unity-engine-core
frostebite 5572262
Regenerate lockfile against fixed unity-engine-core commit
frostebite 2b319cb
Regenerate lockfile against unity-engine-core's Dockerfile fix
frostebite 290b714
feat: rework thin wrapper to invoke game-ci/cli as a subprocess
frostebite 08c55f3
fix: download and extract the release archive, not a bare binary
frostebite d3875bf
style: fix oxfmt formatting on download-cli.ts
frostebite db1bae4
ci: give requestActivation a real Unity project fixture
frostebite 98566f8
feat: cache the game-ci CLI download even when cliVersion=latest
frostebite 62ed347
ci: retrigger verification with today's game-ci/cli fixes (v0.1.41)
frostebite c7713bc
fix: bump @actions/cache to v4 (v3's cache service backend was sunset…
frostebite 6c3e165
fix: validate cliVersion before URL/path construction, remove passWit…
frostebite 7bbd5b0
fix: never cache the "latest" CLI download, only pinned versions
frostebite ac4fb95
fix(deps): bump @actions/cache to v5 to drop vulnerable uuid transitive
frostebite b883948
chore(security): ignore unfixable @actions/glob ReDoS in Snyk policy
frostebite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Snyk (https://snyk.io) policy file, patches or ignores known vulnerabilities. | ||
| version: v1.25.0 | ||
| ignore: | ||
| SNYK-JS-ACTIONSGLOB-11484208: | ||
| - '*': | ||
| reason: >- | ||
| ReDoS in @actions/glob's globEscape (CVE-2025-5890). Snyk lists every | ||
| published version as affected - the upstream fix is on master but has | ||
| not been released - so there is no version of @actions/glob to upgrade | ||
| to. It reaches this action only as a transitive dependency of | ||
| @actions/cache, which we use to cache the game-ci CLI download. | ||
|
|
||
| Not reachable with attacker-controlled input here: the only paths | ||
| handed to @actions/cache are built by cacheDirFor() in | ||
| src/download-cli.ts as os.tmpdir()/game-ci-cli-cache/<version>, and | ||
| <version> is validated against PINNED_VERSION_PATTERN before it is | ||
| used. No user-supplied glob pattern reaches globEscape. | ||
|
|
||
| Revisit when @actions/glob publishes a release containing the fix, | ||
| then drop this entry and bump the dependency. | ||
| expires: 2027-03-04T00:00:00.000Z | ||
| created: 2026-09-04T00:00:00.000Z | ||
| patch: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this isn't actually a behavioural change, possibly breaking?