Skip to content

fix(windows): retry/backoff and serial-mode return fix on Docker path - #213

Merged
frostebite merged 1 commit into
mainfrom
fix/windows-docker-license-return
Aug 28, 2026
Merged

frostebite merged 1 commit into
mainfrom
fix/windows-docker-license-return

Conversation

@frostebite

Copy link
Copy Markdown
Member

Summary

  • `windows/steps/return_license.ps1` (Docker-container script set): serial-mode return was missing `-username`/`-password`, so Unity attempted a ULF-style return instead of a serial return and failed immediately with "Serial number unavailable for ULF return" - confirmed live in unity-test-runner#310's Windows Docker matrix. Also had zero retry logic, unlike every other return script.
  • `windows/steps/activate.ps1` (same script set): had no retry/backoff logic at all, unlike mac/ubuntu's equivalents. Also now prefers serial credentials over personal-license when both are configured, matching the priority fix already shipped everywhere else (fix: prefer serial credentials over personal-license when both are set #206).

Test plan

  • `scripts/validate-platform-scripts.sh` passes
  • Both edited files parse cleanly via PowerShell's own parser (`[System.Management.Automation.Language.Parser]::ParseFile`)
  • Re-verify against unity-test-runner#310's live Windows Docker matrix once merged/released

…path

windows/steps/activate.ps1 and windows/steps/return_license.ps1 (the
Docker-container script set used by unity-test-runner and unity-builder's
Windows matrix) never got the retry/exponential-backoff treatment applied
everywhere else this session, and return_license.ps1's serial branch was
missing -username/-password entirely.

Confirmed live via unity-test-runner#310's Windows Docker jobs: license
return failed on the very first attempt with "Serial number unavailable
for ULF return" (Unity falls back to a ULF-style return when it doesn't
know the license was serial-activated) and no retry ever happened.

- return_license.ps1: serial branch now passes -username/-password
  (matching mac/steps/return_license.sh and the host-mode
  windows/return_license.ps1), and both branches retry with exponential
  backoff on known-transient signatures.
- activate.ps1: all three branches (personal/serial/licensing-server) now
  retry with exponential backoff, and serial credentials are preferred
  over personal-license whenever both are configured, matching the
  priority fix already applied to every other activate script.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • dist/platforms/windows/steps/activate.ps1 is excluded by !**/dist/**
  • dist/platforms/windows/steps/return_license.ps1 is excluded by !**/dist/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e5af89a6-9da2-4f51-a3d8-ded7845e6cc1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@frostebite
frostebite merged commit 8b11db4 into main Aug 28, 2026
15 checks passed
@frostebite
frostebite deleted the fix/windows-docker-license-return branch August 28, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant